edit page has duplicated "view-wizard-controls" in html tags

Bug #1821995 reported by Steven
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon

Bug Description

BUG SUMMARY:
When editing a page, if we inspect the html we can see there are two elements with the id="view-wizard-controls". All id's in html tags should be unique.
We need to fix this either for the form that pop's up when adding a block to the page by clicking on the block menu, or fix it for the modal that contains it.
==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
1) Mahara user exists
2) developer tools are open to view the code

TEST STEPS:
------------------------
1) Log in as Mahara user
2) Create a portfolio page and add a block (any will do)
3) Using the dev tools confirm there are no duplicate ID's

Expected Result: No duplicate ID's are found on the page

Actual Result: Found a duplicate ID on the page (id="view-wizard-controls")

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9743

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 19.04.0
Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
1) Mahara user exists
2) developer tools are open to view the code

TEST STEPS:
------------------------
1) Log in as Mahara user
2) Create a portfolio page and add a block (any will do)
3) Using the dev tools confirm there are no duplicate ID's

Expected Result: No duplicate ID's are found on the page

Actual Result: As expected ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9743
Committed: https://git.mahara.org/mahara/mahara/commit/5880a0d21f754f3cc75e9601205a67ce9d1cfdc2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 5880a0d21f754f3cc75e9601205a67ce9d1cfdc2
Author: Robert Lyon <email address hidden>
Date: Thu Apr 11 09:01:28 2019 +1200

Bug 1821995: Avoid duplicate 'view-wizard-controls' id on page edit

As valid HTML should have only unique ids for elements on a page

Change-Id: I21dce982cc9ad3a9dd2d754d4621f741f712484a
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9750

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9750
Committed: https://git.mahara.org/mahara/mahara/commit/8b7940de72b18328b8797f9adef70fa021a87182
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 8b7940de72b18328b8797f9adef70fa021a87182
Author: Robert Lyon <email address hidden>
Date: Thu Apr 11 09:01:28 2019 +1200

Bug 1821995: Avoid duplicate 'view-wizard-controls' id on page edit

As valid HTML should have only unique ids for elements on a page

Change-Id: I21dce982cc9ad3a9dd2d754d4621f741f712484a
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5880a0d21f754f3cc75e9601205a67ce9d1cfdc2)

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.