Health_check 0.02.09 expects /proc/timer_stats and cannot collect events

Bug #1821181 reported by Igor Ljubuncic
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
health-check (Ubuntu)
Fix Released
High
Colin Ian King
Bionic
Fix Released
Undecided
Colin Ian King

Bug Description

== SRU Request BIONIC ==

== Justification ==

Newer kernels in Bionic don't support the older legacy /proc/timer_stats interface that health-check used to use. This was deprecated in health-check 0.03.00 onwards found in Cosmic+. Backport the removal of the /proc/timer_stats interface usage to Bionic's version of health-check to remove the /proc/timer_stats warning message.

== How to reproduce ==

Run health-check and one will see the error message, e.g.

sudo health-check pwd

"Cannot open /proc/timer_stats"

With the fix this error message does not occur.

== Regression Potential ==

These are backports of upstream health-check patches. They remove old redundant code and don't touch other health-check functionality; hence regression potential is small.

-----

Running health_check 0.02.09 results in the following error:

Cannot open /proc/timer_stats.

This struct does not exist:

ls: cannot access '/proc/timer_stats': No such file or directory

This on:

lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.2 LTS
Release: 18.04
Codename: bionic

Testing version 0.03.00 from git tip works correctly.

Changed in health-check (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

We required the following commit:

commit 7f61fdc66efdef15bd17f1f020d8ab63835243d2 (HEAD, refs/bisect/bad)
Author: Colin Ian King <email address hidden>
Date: Sat Jun 16 19:48:57 2018 +0100

    remove event metrics since newer kernels don't support this API

    Signed-off-by: Colin Ian King <email address hidden>

description: updated
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Igor, or anyone else affected,

Accepted health-check into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/health-check/0.02.09-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in health-check (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Changed in health-check (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Colin Ian King (colin-king) wrote :

Verified with the -proposed health-check 0.02.09-1ubuntu1 on Ubuntu bionic amd64; the "Cannot open /proc/timer_stats" message no longer appears, so this is now fixed.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Changed in health-check (Ubuntu Bionic):
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for health-check has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package health-check - 0.02.09-1ubuntu1

---------------
health-check (0.02.09-1ubuntu1) bionic; urgency=medium

  * Remove trace events as this is no longer supported (LP: #1821181)
    - modern kernels don't support the sysfs interface so removing
      the trace event handlong the best way forward to avoid confusing
      error messages. Upstream commits:
    - 7f61fdc66efdef1 ("remove event metrics since newer kernels
      don't support this API")
    - 608913097b6de23 ("Remove events.h and references to timer stats")

 -- Colin King <email address hidden> Thu, 21 Mar 2018 16:15:14 +0000

Changed in health-check (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.