Pcbnew: Zone visibility and add zone buttons use the same icon.

Bug #1818867 reported by BobZ18188
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Jeff Young

Bug Description

Pcbnew has two different buttons with the same icon. One is "Show filled areas in zones." The other is "Add filled zones." I am in the process of learning KiCad. I wanted to add a filled zone. The instructions showed the button icon. I clicked on wrong button with the right icon. This did not work. I tried it a few times to confirm but was stuck. I probably assumed that two buttons with the same icon would have the same function.

As a MINIMAL change, one way would be to (mirror or rotate) the icon on one button relative to the other so that they are not identical. That would at least hint to the beginner following instructions that these two buttons might be different.

Application: kicad
Version: (5.0.2)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew ui
Seth Hillbrand (sethh)
Changed in kicad:
importance: Undecided → Wishlist
milestone: none → 6.0.0-rc1
status: New → Triaged
Rene Poeschl (poeschlr)
summary: - Pcbnew two different buttons with same icon
+ Pcbnew: Zone visibility and add zone buttons use the same icon.
Revision history for this message
Rene Poeschl (poeschlr) wrote :

I am not really sure if i would clasify this as a wishlist item to be honest. It is a clear bug if you want kicad to be accessible by people with bad vision (colour blindness for example.)

I would agree that it has low priority but wishlist implies that everything is ok as it is now. (Unless i have the wrong idea about what wishlist means. Just for comparison, a bug report for better tooltips has been marked as low priority. [1] So i get the feeling that there is not really a clear guideline in place which report should be put into which category.)

[1]: https://bugs.launchpad.net/kicad/+bug/1804932

Revision history for this message
Seth Hillbrand (sethh) wrote :

Fair enough.

Changed in kicad:
importance: Wishlist → Low
Revision history for this message
Nick Østergaard (nickoe) wrote :

It is not the same icon. It has the same shape, but not the same colors.

Changed in kicad:
status: Triaged → Incomplete
Revision history for this message
BobZ18188 (bobz18188) wrote : RE: [Bug 1818867] Re: Pcbnew: Zone visibility and add zone buttons use the same icon.

Hi, Nick

Thank you for responding.

This color difference may be apparent to somebody who already knows it. However to someone who is learning the software it is not obvious. It was only after looking at it many times and after someone mentioned that they were different that I was able to see that.

Also there are two rows of buttons on opposite sides of the screen. You may know of a functional difference between those two rows but none is shown.

I would think that one button could be (rotated or mirrored) relative to the other and this would be a more obvious difference.

Bob Zwicker
<email address hidden>

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Nick Østergaard
Sent: Monday, March 11, 2019 6:38 AM
To: <email address hidden>
Subject: [Bug 1818867] Re: Pcbnew: Zone visibility and add zone buttons use the same icon.

It is not the same icon. It has the same shape, but not the same colors.

** Changed in: kicad
       Status: Triaged => Incomplete

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1818867

Title:
  Pcbnew: Zone visibility and add zone buttons use the same icon.

Status in KiCad:
  Incomplete

Bug description:
  Pcbnew has two different buttons with the same icon. One is "Show
  filled areas in zones." The other is "Add filled zones." I am in the
  process of learning KiCad. I wanted to add a filled zone. The
  instructions showed the button icon. I clicked on wrong button with
  the right icon. This did not work. I tried it a few times to confirm
  but was stuck. I probably assumed that two buttons with the same icon
  would have the same function.

  As a MINIMAL change, one way would be to (mirror or rotate) the icon
  on one button relative to the other so that they are not identical.
  That would at least hint to the beginner following instructions that
  these two buttons might be different.

  Application: kicad
  Version: (5.0.2)-1, release build
  Libraries:
      wxWidgets 3.0.4
      libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
  Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
  Build Info:
      wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
      Boost: 1.68.0
      OpenCASCADE Community Edition: 6.9.1
      Curl: 7.61.1
      Compiler: GCC 8.2.0 with C++ ABI 1013

  Build settings:
      USE_WX_GRAPHICS_CONTEXT=OFF
      USE_WX_OVERLAY=OFF
      KICAD_SCRIPTING=ON
      KICAD_SCRIPTING_MODULES=ON
      KICAD_SCRIPTING_WXPYTHON=ON
      KICAD_SCRIPTING_ACTION_MENU=ON
      BUILD_GITHUB_PLUGIN=ON
      KICAD_USE_OCE=ON
      KICAD_USE_OCC=OFF
      KICAD_SPICE=ON

To manage notifications about this bug go to:
https://bugs.launchpad.net/kicad/+bug/1818867/+subscriptions

Revision history for this message
Rene Poeschl (poeschlr) wrote :

The colour difference is extremely subtle to say the least. Maybe an idea would be to mark the left toolbar as view options toolbar in some way. Or alternatively add some identifier that the button on the right is for adding zones while the left one is for selecting the view mode (A small plus on the button to add zone and a small display on the one for the viewing options come to mind.)

Revision history for this message
BobZ18188 (bobz18188) wrote :

I see that the trace image in one button (R-G-B) is 128 - 128 - 128 and the other is 0 - 128 - 0. That sounds significant, but I think the relatively small size of the area with differentiated color makes it more difficult to discern.

Bob Zwicker
<email address hidden>

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Rene Poeschl
Sent: Wednesday, March 20, 2019 11:20 AM
To: <email address hidden>
Subject: [Bug 1818867] Re: Pcbnew: Zone visibility and add zone buttons use the same icon.

The colour difference is extremely subtle to say the least. Maybe an
idea would be to mark the left toolbar as view options toolbar in some
way. Or alternatively add some identifier that the button on the right
is for adding zones while the left one is for selecting the view mode (A
small plus on the button to add zone and a small display on the one for
the viewing options come to mind.)

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1818867

Title:
  Pcbnew: Zone visibility and add zone buttons use the same icon.

Status in KiCad:
  Incomplete

Bug description:
  Pcbnew has two different buttons with the same icon. One is "Show
  filled areas in zones." The other is "Add filled zones." I am in the
  process of learning KiCad. I wanted to add a filled zone. The
  instructions showed the button icon. I clicked on wrong button with
  the right icon. This did not work. I tried it a few times to confirm
  but was stuck. I probably assumed that two buttons with the same icon
  would have the same function.

  As a MINIMAL change, one way would be to (mirror or rotate) the icon
  on one button relative to the other so that they are not identical.
  That would at least hint to the beginner following instructions that
  these two buttons might be different.

  Application: kicad
  Version: (5.0.2)-1, release build
  Libraries:
      wxWidgets 3.0.4
      libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
  Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
  Build Info:
      wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
      Boost: 1.68.0
      OpenCASCADE Community Edition: 6.9.1
      Curl: 7.61.1
      Compiler: GCC 8.2.0 with C++ ABI 1013

  Build settings:
      USE_WX_GRAPHICS_CONTEXT=OFF
      USE_WX_OVERLAY=OFF
      KICAD_SCRIPTING=ON
      KICAD_SCRIPTING_MODULES=ON
      KICAD_SCRIPTING_WXPYTHON=ON
      KICAD_SCRIPTING_ACTION_MENU=ON
      BUILD_GITHUB_PLUGIN=ON
      KICAD_USE_OCE=ON
      KICAD_USE_OCC=OFF
      KICAD_SPICE=ON

To manage notifications about this bug go to:
https://bugs.launchpad.net/kicad/+bug/1818867/+subscriptions

tags: added: pcbnew ui
Changed in kicad:
status: Incomplete → Confirmed
status: Confirmed → Triaged
Jeff Young (jeyjey)
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 6fb96891b15b7b55fdb51c368bb8a5b698e6ae83
https://git.launchpad.net/kicad/patch/?id=6fb96891b15b7b55fdb51c368bb8a5b698e6ae83

Changed in kicad:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.