Hibinit-agent configures GRUB referring to root partition as resume=/dev/root

[Balint Reczey]

[Impact]

 * The kernel can't find /dev/root when booting initramfsless thus can't resume from hibernation
 * The fix sets resume=... to the same identifier passed as root=... on the kernel command when the swap file is found to be on /dev/root.

[Test Case]

 * (Install and) start hibinit-agent on an EC2 instance supporting hibernation, then when it started successfully verify the grub configuration:
$ grep -m 1 root= /boot/grub/grub.cfg
   linux /boot/vmlinuz-4.18.0-1008-aws root=PARTUUID=6b4ea835-01 ro console=tty1 console=ttyS0 nvme.io_timeout=4294967295 no_console_suspend=1 resume_offset=438272 resume=PARTUUID=6b4ea835-01

  resume=... must not refer to /dev/root with the default configuration, but to a block device known to the kernel without using initramfs.

[Regression Potential]

 * Hibinit-agent may parse the grub configuration file incorrectly and set a wrong partition to resume from. Since the fix is quite small and the number of variants of grub configurations is also small this regression is unlikely.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu3

---------------
ec2-hibinit-agent (1.0.0-0ubuntu3) disco; urgency=medium

  * Refer to root partition in resume=... the same way as GRUB2 refers to it
    (LP: #1818150)

 -- Balint Reczey <email address hidden> Thu, 28 Feb 2019 23:25:57 +0100

[Brian Murray (brian-murray)]

Hello Balint, or anyone else affected,

Accepted ec2-hibinit-agent into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ec2-hibinit-agent/1.0.0-0ubuntu4~18.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Balint, or anyone else affected,

Accepted ec2-hibinit-agent into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ec2-hibinit-agent/1.0.0-0ubuntu4~18.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Balint, or anyone else affected,

Accepted ec2-hibinit-agent into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ec2-hibinit-agent/1.0.0-0ubuntu4~16.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Balint, or anyone else affected,

Accepted ec2-hibinit-agent into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ec2-hibinit-agent/1.0.0-0ubuntu4~14.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Balint Reczey (rbalint)]

Tested on Cosmic, Bionic and Xenial with the latest version in -proposed:

ubuntu@ip-172-31-11-18:~$ dpkg -l ec2-hibinit-agent | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-=================-======================-============-=================================
ii ec2-hibinit-agent 1.0.0-0ubuntu4~18.10.0 all Amazon EC2 hibernation agent
ubuntu@ip-172-31-11-18:~$ grep -m 1 root= /boot/grub/grub.cfg
   linux /boot/vmlinuz-4.18.0-1011-aws root=PARTUUID=71d081c0-01 ro console=tty1 console=ttyS0 nvme_core.io_timeout=4294967295 no_console_suspend=1 resume_offset=245760 resume=PARTUUID=71d081c0-01

ubuntu@ip-172-31-7-41:~$ dpkg -l ec2-hibinit-agent | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-=================-======================-============-=================================
ii ec2-hibinit-agent 1.0.0-0ubuntu4~18.04.0 all Amazon EC2 hibernation agent
ubuntu@ip-172-31-7-41:~$ grep -m 1 root= /boot/grub/grub.cfg
        linux /boot/vmlinuz-4.15.0-1033-aws root=UUID=b5361850-7320-445b-b1c9-a8b294830484 ro console=tty1 console=ttyS0 nvme.io_timeout=4294967295 no_console_suspend=1 resume_offset=235520 resume=/dev/xvda1

ubuntu@ip-172-31-12-48:~$ dpkg -l ec2-hibinit-agent | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-=================-======================-============-=================================
ii ec2-hibinit-agent 1.0.0-0ubuntu4~16.04.0 all Amazon EC2 hibernation agent
ubuntu@ip-172-31-12-48:~$ grep -m 1 root= /boot/grub/grub.cfg
        linux /boot/vmlinuz-4.4.0-1077-aws root=UUID=7d8f7a6c-6fdc-4cfe-a376-95b51a59f117 ro console=tty1 console=ttyS0 nvme.io_timeout=4294967295 nvme_core.io_timeout=4294967295 no_console_suspend=1 resume_offset=346112 resume=/dev/xvda1

[Balint Reczey (rbalint)]

Trusty will not include the package.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu4~18.10.0

---------------
ec2-hibinit-agent (1.0.0-0ubuntu4~18.10.0) cosmic; urgency=medium

  * Backport to Cosmic (LP: #1812166)

ec2-hibinit-agent (1.0.0-0ubuntu4) disco; urgency=medium

  * Update grub configuration snippet even when it exists but has outdated
    content

ec2-hibinit-agent (1.0.0-0ubuntu3) disco; urgency=medium

  * Refer to root partition in resume=... the same way as GRUB2 refers to it
    (LP: #1818150)

ec2-hibinit-agent (1.0.0-0ubuntu2) disco; urgency=medium

  * debian/gbp.conf: Use ubuntu/ prefix for tags
  * Silence swapoff when purging the package
  * Detect disabled hibernation with Python 3's urllib, too. (LP: #1817926)

ec2-hibinit-agent (1.0.0-0ubuntu1) disco; urgency=medium

  * Initial release based on packaging of hibagent

 -- Balint Reczey <email address hidden> Fri, 01 Mar 2019 23:05:14 +0100

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for ec2-hibinit-agent has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu4~18.04.0

---------------
ec2-hibinit-agent (1.0.0-0ubuntu4~18.04.0) bionic; urgency=medium

  * Backport to Bionic (LP: #1812166)

ec2-hibinit-agent (1.0.0-0ubuntu4) disco; urgency=medium

  * Update grub configuration snippet even when it exists but has outdated
    content

ec2-hibinit-agent (1.0.0-0ubuntu3) disco; urgency=medium

  * Refer to root partition in resume=... the same way as GRUB2 refers to it
    (LP: #1818150)

ec2-hibinit-agent (1.0.0-0ubuntu2) disco; urgency=medium

  * debian/gbp.conf: Use ubuntu/ prefix for tags
  * Silence swapoff when purging the package
  * Detect disabled hibernation with Python 3's urllib, too. (LP: #1817926)

ec2-hibinit-agent (1.0.0-0ubuntu1) disco; urgency=medium

  * Initial release based on packaging of hibagent

 -- Balint Reczey <email address hidden> Fri, 01 Mar 2019 23:08:55 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu4~16.04.0

---------------
ec2-hibinit-agent (1.0.0-0ubuntu4~16.04.0) xenial; urgency=medium

  * Backport to Xenial (LP: #1812166)

ec2-hibinit-agent (1.0.0-0ubuntu4) disco; urgency=medium

  * Update grub configuration snippet even when it exists but has outdated
    content

ec2-hibinit-agent (1.0.0-0ubuntu3) disco; urgency=medium

  * Refer to root partition in resume=... the same way as GRUB2 refers to it
    (LP: #1818150)

ec2-hibinit-agent (1.0.0-0ubuntu2) disco; urgency=medium

  * debian/gbp.conf: Use ubuntu/ prefix for tags
  * Silence swapoff when purging the package
  * Detect disabled hibernation with Python 3's urllib, too. (LP: #1817926)

ec2-hibinit-agent (1.0.0-0ubuntu1) disco; urgency=medium

  * Initial release based on packaging of hibagent

 -- Balint Reczey <email address hidden> Fri, 01 Mar 2019 23:16:18 +0100