[SRU] Update geary to bug-fix release 0.12.4 in Bionic

[Amr Ibrahim]

IMPACT
-------
Geary 0.12.4 is a bug-fix release from the 0.12.x branch. Geary jumped afterwards to 0.13.x then now follows GNOME versioning at 3.32.x.

Version 0.12.4
~~~~~~~~~~~~~~
Released: 2018-08-29

Bug fixes included in this release:
 * Fix handling folder names with IMAP reserved characters, such as
   backslashes. Issue #40
 * Fix dialog windows not focused after being first shown. Issue #43
 * Actually include the fix for "Move to folder" selection bug. Issue #24
 * Fix build under vala >= 0.41. Issue #86
 * Fixes for miscellaneous crashers

Version 0.12.3
~~~~~~~~~~~~~~
Released: 2018-07-14

Bug fixes included in this release:
 * Not syncing mail using Turkish locale. Bug 795906
 * Fix crash saving an attachment with unknown content type
 * Fix crash in secret_collection_get_locked. Bug 795328
 * "Move to folder" selection bug. Issue #24
 * Subfolders with special folders not displayed in list. Issue #11
 * Add OARS metadata for Flathub

Thanks to all who contributed code fixes and enhancements to this
release:
 * Nick Richards

Version 0.12.2
~~~~~~~~~~~~~~
Released: 2018-04-24

Bug fixes included in this release:
 * Fix being unable to remove attachments from a draft. Bug 792555.
 * Ensure drafts are removed when composer from address changes accounts. Bug
   778976.
 * Workaround composer info label being too long. Bug 790435.
 * Ensure embedded composer is always scrolled to when opened. Bug 778027.
 * Don't display quote expander buttons when printing a message. Bug 795216.
 * Fix composer detach button position and visibility. Bug 793710.
 * Actually fix second multipart/digest message body not being displayed. Bug
   788637.
 * Ensure gnome-control-centre knows in advance Geary uses notifications.
 * Fix gnome-shell notifications missing an icon under flatpak. Bug 790103.
 * Fix message body quote button styling under WebKitGTK 2.20.
 * Don't show unused header widgets when showing a message via notifications.
 * Work around present() not actually raising windows under Wayland. Bug
   776881.
 * Reduce CPU use when idle. Bug 783025.
 * Fix some serious run-time memory leaks.

Thanks also to all who contributed translations, for the user
interface:
 * Daniel Mustieles (es)
 * Stas Solovey (ru)
 * Мирослав Николић (sr) (sr@latin)

TEST CASE
----------
- Use Geary as usual to send and receive emails in Gmail, Outlook or other IMAP accounts.

REGRESSION POTENTIAL
---------------------
Geary upstream has two branches, the master branch, which receives new features and bug fixes, and the stable 0.12.x branch, which receives only bug fixes. It would be beneficial for users to get the latest maintenance release 0.12.4.

I have done a straight no-change backport from Disco to Bionic to show that 0.12.4 builds, installs and runs fine on Bionic.
https://launchpad.net/~amribrahim1987/+archive/ubuntu/ppa/+build/16383090

[Amr Ibrahim (amribrahim1987)]

I'm subscribing Michael Gratton, the upstream maintainer, maybe he could say something here, whether this is a bug-fix release or not.

[Michael Gratton (mjog)]

Hey, 0.12.4 is indeed a bug fix release. It would be good to have that in Bionic.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "geary_0.12.0-1ubuntu1_0.12.4-4~ubuntu18.04.1~ppa1.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Simon Quigley (tsimonq2)]

Hi Amr, thanks for your work on this!

Could you please edit the bug description to follow the SRU template? You can find that here: https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Please resubscribe sponsors when that is done.

[Simon Quigley (tsimonq2)]

Uploaded to Bionic with minor changelog edits.

[Robie Basak (racb)]

This would place the version of geary higher in Bionic than in Cosmic, which will cause problems as users upgrade to Cosmic. One way to resolve this would be to also update (and verify) Cosmic, or wait until Cosmic is EOL.

[Amr Ibrahim (amribrahim1987)]

No one cares about Cosmic at the moment. So let's wait until it's EOL.

[Steve Langasek (vorlon)]

It would be trivial to upload the package with a version number that sorts properly less than the version in cosmic so that upgrades work without issue (or even to base this on the cosmic version, since the changes from 0.12.4-2 and 0.12.4-4 don't seem relevant on bionic). We also do not want to leave this upload in the queue for months until cosmic has reached EOL. So I am rejecting this package from the queue now. It can be reuploaded at any time with a proper version number, or in July with the same version number.

[Steve Langasek (vorlon)]

An upload of geary to bionic-proposed has been rejected from the upload queue for the following reason: "Wrong version number for upload which sorts > cosmic".

[Gunnar Hjalmarsson (gunnarhj)]

The changelog in the now rejected upload to bionic-proposed claimed to fix bug #1779574. Well, it would not have done so. Actually it would have resulted in geary being shipped untranslated. It's not practicable to enable Ubuntu's language packs retroactively.

Attached please find my proposed modifications compared to the debdiff added in comment #3. With those mods the translations won't be stripped, and bug #1779574 will be really fixed.

Whenever the package is re-uploaded to bionic-proposed, please take these changes into account.

[Amr Ibrahim (amribrahim1987)]

Please re-upload the package incorporating the modifications in comment #11 now that Cosmic is dead.

[fossfreedom (fossfreedom)]

I have made some tiny tweaks to the changelog itself, but as requested I have merged in #3 with #11 and successfully built the package against all target architectures here https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/geary-test/+packages

I have uploaded this to ubuntu and the SRU team will now review.

cheers.

[Sebastien Bacher (seb128)]

(unsubscribing sponsors since the change have been uploaded)

[Timo Aaltonen (tjaalton)]

Hello Amr, or anyone else affected,

Accepted geary into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/geary/0.12.4-4~ubuntu18.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Amr Ibrahim (amribrahim1987)]

I confirm that geary 0.12.4-4~ubuntu18.04.3 from bionic-proposed is working nicely in sending and receiving emails.

[Launchpad Janitor (janitor)]

This bug was fixed in the package geary - 0.12.4-4~ubuntu18.04.3

---------------
geary (0.12.4-4~ubuntu18.04.3) bionic; urgency=medium

  [ Amr Ibrahim ]
  * Backport to bionic (LP: #1815626)

  [ Gunnar Hjalmarsson ]
  * Handle translations for bionic (LP: #1779574):
    - debian/control.in, debian/control:
      - Don't enable language packs.
    - debian/rules:
      - Prevent dh_translations from removing upstream translations
        from the .desktop files.

 -- David Mohammed <email address hidden> Wed, 02 Oct 2019 22:49:05 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for geary has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.