more usable and simpler layout selector for Mahara pages

[Cecilia Vela Gurovic]

We are planning to improve the layout of mahara pages using the gridstack library.

http://gridstackjs.com/

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9509

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9551

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9556

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9714

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9952

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9953

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9970

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9971

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9972

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9979

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9986

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9992

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10010

[Cecilia Vela Gurovic (ceciliavg)]

Decisions taken for accessibility and upgrade to new layout

* Add identification to each block for screen reader, blocktype and title (if it’s set)

* Fixed layout format for accessible pages: each block will have 12 columns fixed width and will be displayed as a sequence. It should be able to reorder the blocks with the keyboard.

* When adding a block to the bottom or the top of the page, the page should be scrolled to that block

* Floating menu: should have a way to be recognized as a menu by the screen reader. Check the access keys for the menu.

* Add an intro to the page for the screen reader to explain how the page works

* Add accessibility option in the user settings. When it’s enabled new pages will be able to use the fixed accessibility layout

* When copying/creating a view, if the user setting for accessibility is on, there will be an option to have the new page with accessibility fixed layout. This setting will be displayed in the basic section of the page settings under the page title. When copying a collection, the setting will be displayed under the collection title. If this option is changed, the value will be propagated to the collection pages.

Upgrading to new layout

* Keep old layout display for older view that haven’t been edited since the upgrade.

* When creating a new view use gridstack layout. When editing/copying a view with old layout, translate it to the new GS layout, showing a message with the change.

* When editing a page, it needs to be translated from the old layout to the new gridstack layout. There should be a pop-up message to be displayed to inform the user the layout of the view will be changed if they continue editing. There should be a possibility to cancel the edit and keep the old layout. There should also be an option for not showing these messages in the future.

* Automatically translate the site pages to the new GS layout

[Cecilia Vela Gurovic (ceciliavg)]

This is a library we could use for reordering blocks in accessibility fixed layout

https://schne324.github.io/dragon-drop/demo/

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10145

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10155

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10222

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10223

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10230

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10236

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10247

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10249

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10251

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10297

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10346

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10386

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10394

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10398

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10386
Committed: https://git.mahara.org/mahara/mahara/commit/24e838cf0904ef79ec129fc053eb1c91af76ed6b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 24e838cf0904ef79ec129fc053eb1c91af76ed6b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 1 14:17:46 2019 +1300

Bug 1813987: removing layout tables from install

- removing
'usr_custom_layout'
'view_layout_rows_columns'
'view_layout'
'view_layout_columns'

behatbitneeded

Change-Id: Ic53029dfc33b6366c38750d1453cbb64fd9c317e

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10394
Committed: https://git.mahara.org/mahara/mahara/commit/279c2d49bb958ef9c9399ef2ded337b7420bf7e2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 279c2d49bb958ef9c9399ef2ded337b7420bf7e2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 4 09:56:25 2019 +1300

Bug 1813987: checking old layout tables exists before using them

- when deleting an institution
- added a function to simulate the content of
view_layout_column table that was deleted.
This is needed when importing a portfolio with
old layout
- removed function addcustomlayout and some
other code not used anymore
- removed function get_layoutrows that was used
when editing old layouts

behatnotneeded

Change-Id: Ibebf50103bf1811894e75a21a668c4700283e703

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10297
Committed: https://git.mahara.org/mahara/mahara/commit/ccc2446d7451e3d545865e6d70f089045f663799
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ccc2446d7451e3d545865e6d70f089045f663799
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Sep 5 16:48:34 2019 +1200

Bug 1813987: Blocks display fixes

- assessment block: tinymce and the asseesment js
need to be initialized after the block is loaded
- signoff block: sing-off modal is showing now
- embedded media init functions need to be loaded after
the blocks are added to the grid
- wall post block initializes the tinyMCE after it's loaded
and refreshes the content of the block after a new post is made
- comment block: update block size when adding a comment
- scrolling to the block when a new one is added
- modified the text for button to add a new block to the page
'Drag to add a new block' for normal mode
'Click to add a new block' for accessibility mode
- add a block to the bottom of the page by default so it won't
break the layout
- add SE annotation to the bottom of the page
- added 'Add block' button event handlers after trnaslating a view
- annotation feedback loads the tinyMCE

behatnotneeded

Change-Id: I7642cacde729a2a85b497e077452de792ec72eb7

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10251
Committed: https://git.mahara.org/mahara/mahara/commit/250829882ef38ef6da690beba4677b8ecb4fc8db
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 250829882ef38ef6da690beba4677b8ecb4fc8db
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 8 17:01:23 2019 +1200

Bug 1813987: Accessibility settings and layout

- Added an option to set the profile to accessible.
This can be set in account preferences and
enables one extra field in the settings
of a view, in the basic settings section, to make
the layout accessible.

- by default, if the user account is accessible then
the pages will be crated as accessible.
To have a non accessible page, the option un view settings
needs to be set as 'No'

- Accessible layout only allows to add blocks with width=12
that is the same with of the grid.
This makes the blocks show as a sequence one on top of the other
like a list. The user can only reorder the position
they have in the list.

- When a page is accessible, the adding a block
by drag & drop is disabled

- Reordering of blocks is accessible by keyborad

- The 'add block' button is reachable by keyboard

- add an intro to the page for the screen reader
to explain how the page works

- add identification to each block for screen reader,
blocktype and title (if it���s set)

TODO
* When adding a block to the bottom or the top of the page,
the page should be scrolled to that block

* Floating menu: should have a way to be recognized as a menu
by the screen reader. Check the access keys for the menu.

behatnotneeded

Change-Id: I08417f0f11d747a67900c88c2f675ef5f85b7499

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10249
Committed: https://git.mahara.org/mahara/mahara/commit/69916a3da2aeb8087c12d17a783e46049c4e5ecd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 69916a3da2aeb8087c12d17a783e46049c4e5ecd
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Aug 7 17:26:07 2019 +1200

Bug 1813987: User should confirm before the view is translated

there is an account preference we can set for showing
a warning message before translating the layout of an old view.

By default it's true. It can be set to false in the account preferences
or by selecting the option when the message is displayed.
if this preference is set to
true: if we want to edit a view with old layout,
a message will be displayed to confirm we want to translate the layout.
false: The view gets translated on edit without asking the user.

The message has the options to accept, cancel or don't ask again.

cancel: redirects to the displayed view
don't ask again: sets account preference to false but can be reverted
in account preferences.
accept: will redirect to the view edit page with a parameter
saying the user accepted the translation

behatnotneeded

Change-Id: I84e1a86d3bb494a1955da9cbfbde996b555bb132

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10236
Committed: https://git.mahara.org/mahara/mahara/commit/af08a13805b48adddb4da1f98fa1ad8e52000e55
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit af08a13805b48adddb4da1f98fa1ad8e52000e55
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 1 14:25:12 2019 +1200

Bug 1813987: Importing views with grid layout

Importing views and collection with new grid layout

- leap2A files containing views/collections with
new grid layout are imported and created with the new layout

- leap2A files containing collections/view with old layout
will be created with a grid layout. This new layout is
the translation of the old layout they had in the leap2A file.
The heights of the blocks will be updated when the
views are first displayed in the browser.

behatnotneeded

Change-Id: Ia43b7a5c11109023d3caa65ba16e3b6aebcdbe75

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10346
Committed: https://git.mahara.org/mahara/mahara/commit/9cf3d8eb493ec2b8d3d63cad2f2e6ddec7527c85
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9cf3d8eb493ec2b8d3d63cad2f2e6ddec7527c85
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Sep 13 18:09:34 2019 +1200

Bug 1813987: Behat - block creation

- Data generator creates blocks for new gridstack layout
- we don't look for nodes inside script elements

behatnotneeded

Change-Id: I0e791c431ab6b80e75ae397290a20b3ec9fba836

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10247
Committed: https://git.mahara.org/mahara/mahara/commit/1a1d2a69ef7d860733973610cb602dc4f5b8f5aa
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1a1d2a69ef7d860733973610cb602dc4f5b8f5aa
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Aug 7 10:21:36 2019 +1200

Bug 1813987: Creating a view via tags with gridstack

when creating blocks via tags
- the position of the copied blocks in the new view
will be one on top of the other
- if the block comes from a view with grid layout,
it will take the width & height from its dimensions
- if the block comes from an old layout view,
it will be created with default dimensions
width = 4
height = 3

behatnotneeded

Change-Id: I465e09fa4af6742913302c7ef278708c3cb627bc

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10230
Committed: https://git.mahara.org/mahara/mahara/commit/b6cd876f38bec044914ce688b1d9ea455664e409
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b6cd876f38bec044914ce688b1d9ea455664e409
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Jul 30 17:13:03 2019 +1200

Bug 1813987: Exporting views with grid layout

In exporting section:
/export/index.php

- Show preview of page both for old layout pages and
new grid layout
- Export views and collections with new grid layout
in html
- Export views and collections with new grid layout
in leap2A
- views with old layout are exported as before

NOTE
borrow some code from https://reviews.mahara.org/#/c/10157/
as an early rebase (the patch is not on master yet)

behatnotneeded

Change-Id: I0c36c110c6b9ef7ae3edc4d0662a0dbab302684a

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10145
Committed: https://git.mahara.org/mahara/mahara/commit/66c08ce0e95b6c8d17e2989d2938dce8929352d7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 66c08ce0e95b6c8d17e2989d2938dce8929352d7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 5 18:35:03 2019 +1200

Bug 1813987: Making magic block work with gridstack layout

In view edit mode, dragging the button '+' on the
right top menu, will add a block in the page
with dimensions height=3 and width=4

behatnotneeded

Change-Id: I5f4334886f6685bd047cb5bfbf0d59dd3880109a

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10222
Committed: https://git.mahara.org/mahara/mahara/commit/f342e41b6c096d4fabfae645508e4041cb0b8af9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f342e41b6c096d4fabfae645508e4041cb0b8af9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Jul 24 11:40:17 2019 +1200

Bug 1813987: Copying a page (in old or new layout) creates a page with new layout

- Copy a page when original view is using
grid layout
- Copy a page when original view is using
old layout: Translates the original page layout
without modifying it,
and creates a new page with new grid layout
The blocks in the new page will not have height
assigned. The height of the blocks is updated
on first load of the page in the browser.
This can happen when editing the page or displaying it.
- Copy a collection with old layout: creates the new collection
with new grid layout pages. Each page needs to be loaded on the
browser to update the block heights

behatnotneeded

Change-Id: I43b5f9050be192c057cb1803dcd69575c137a9cc

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10223
Committed: https://git.mahara.org/mahara/mahara/commit/7b17b833ebc13071355844cd57f61b8071e1d5ab
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7b17b833ebc13071355844cd57f61b8071e1d5ab
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 26 10:06:27 2019 +1200

Bug 1813987: Make view versioning work with gridstack

- Only allow to create a new version if the view
is using new gridstack layout.

In timeline version section:
- For view versions that were created with old layout,
show them as they are
(we dont translate old view versions to new layout)
- For view versions that are created with new grid layout,
they are also displayed in the timeline view with the new grid
layout

behatnotneeded

Change-Id: I1abdae9e5e547dcc9bce97cac127085786dcac8a

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10010
Committed: https://git.mahara.org/mahara/mahara/commit/15bca1e7bc4acea225193819548f7a44b0e08eff
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 15bca1e7bc4acea225193819548f7a44b0e08eff
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon May 13 10:47:16 2019 +1200

Bug 1813987: Upgrade to translate site views to new layout

behatnotneeded

Change-Id: Ia4f1fa57d317bc2ab81db4b4e41147e06ecc14f6

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10155
Committed: https://git.mahara.org/mahara/mahara/commit/32de0b181b0d06ca1f70e4134d5f8e7760ca10a0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 32de0b181b0d06ca1f70e4134d5f8e7760ca10a0
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jul 11 17:55:44 2019 +1200

Bug 1813987: Translate old views to new gridstack layout on edit

Old layout pages will be displayed as they were
with the old layout.

New pages are created with the new grid layout.

If we try to edit a page with an old layout,
the page will be translated into the new grid layout.

To translate from an old layout to a new grid layout,
we respect the row, column and order of blocks inside each cell.

All blocks in the same row in old layout will be together
in the new layout, and the first block of each column
of the same row are displayed at the same level to each other
in the new layout.

The blocks will respect the column order
they had in the old layout.

A column of the old layout can have many blocks. In the
new grid layout they respect the same order they had.

As we have 12 columns in the new grid layout,
the blocks that where included in a 5 column row,
will be displayed in smaller columns in the new layout.

TODO:
confirmation before trnaslating a page to the new grid layout

behatnotneeded

Change-Id: I46f5cdbacb026519631503437c10d33f1b2800e5

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9992
Committed: https://git.mahara.org/mahara/mahara/commit/0772a2407bfefbb4cede46ac7efcc55de7578c07
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0772a2407bfefbb4cede46ac7efcc55de7578c07
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon May 13 10:31:07 2019 +1200

Bug 1813987: create a block- fixing the saving of a new block

behatnotneeded

Change-Id: Ib20121937f6b7c64df65a620acbca93dd683d18f

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9979
Committed: https://git.mahara.org/mahara/mahara/commit/f9295a81ad4483c1f829c2ecb25192d034e1a770
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f9295a81ad4483c1f829c2ecb25192d034e1a770
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed May 8 15:00:06 2019 +1200

Bug 1813987: remove layout button from navigation

+ Also remove not used templates. They should have been deleted
in commit 84119067083d50b7afd1515d03978dd5d1e196c9
that unifies layout and settings section

behatnotneeded

Change-Id: Icd90bd4980b9be566f7e20aee6271476edafe321

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9971
Committed: https://git.mahara.org/mahara/mahara/commit/b8afbd1599dd83368d2659200e2efe0938ec0920
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b8afbd1599dd83368d2659200e2efe0938ec0920
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue May 7 16:33:59 2019 +1200

Bug 1813987: removing old layout from mahara install

behatnotneeded

Change-Id: If0e93ba7d1ff49fac57fc3d910c4586c9c23d877

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9986
Committed: https://git.mahara.org/mahara/mahara/commit/565776fb60d1e0b1c50f3ac2315b331244a647ab
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 565776fb60d1e0b1c50f3ac2315b331244a647ab
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu May 9 17:52:42 2019 +1200

Bug 1813987: block resizing to fit content

should not resize blocks in view mode

in view mode, if the content of the block is static,
then the block dimensions should not change but the
content of the block should be made smaller

expand the height of a block only if the content is dynamic,
like the 'Journal' block

behatnotneeded

Change-Id: Ie8183736580e7e592b24e36f4a16618b96a5bf4e

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9970
Committed: https://git.mahara.org/mahara/mahara/commit/a5fd2d09e190a7dc08936039ea9e388758f71e51
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a5fd2d09e190a7dc08936039ea9e388758f71e51
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue May 7 15:13:07 2019 +1200

Bug 1813987: Make the comment block work

added a js event 'blocksloaded' to signal the blocks were
loaded in the grid and the are available in the DOM

behatnotneeded

Change-Id: I8f54eab5b5b71c712578d8af0f5684497d2f33bc

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9953
Committed: https://git.mahara.org/mahara/mahara/commit/c0f57e7da518c25352b30ca11a20d9be46205674
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c0f57e7da518c25352b30ca11a20d9be46205674
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri May 3 18:00:06 2019 +1200

Bug 1813987: Display a page in view mode

The blocks saved with the new layout
are now displayed in page edit and view mode

behatnotneeded

Change-Id: Ic8c1011745593be552cc1a4377a7351cc9a04bb9

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9972
Committed: https://git.mahara.org/mahara/mahara/commit/6aadcd020ab6e76bfe8471a6b7c87e675173fd96
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6aadcd020ab6e76bfe8471a6b7c87e675173fd96
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue May 7 19:29:16 2019 +1200

Bug 1813987: Display Dashboard and profile page

+ fix for loading block with ajax
+ also display group page with new layout

behatnotneeded

Change-Id: If93da8afb3069349e5c7612dc41df0faa3394e10

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9952
Committed: https://git.mahara.org/mahara/mahara/commit/6cee4292a93deaeb049c856f7fb2b261eb76fe79
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6cee4292a93deaeb049c856f7fb2b261eb76fe79
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri May 3 17:11:03 2019 +1200

Bug 1813987: allow to choose add block to bottom/top of the grid

- Also removed code in the pop-up for adding a new block to a page:
The js functions that update the select to choose the position
of a new block inside a column were removed.

behatnotneeded

Change-Id: Ie20f7bbfc98c6b9f4a61f291fcaf23d368d077e0

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9508
Committed: https://git.mahara.org/mahara/mahara/commit/ca51ed794b745b991f734f88b61cdeec3d182b68
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ca51ed794b745b991f734f88b61cdeec3d182b68
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jan 31 10:01:52 2019 +1300

Bug 1813987: Creating tables for gridstack page blocks

and remove 'unique constraint' on block_instance table on
view,row,column and order columns

behatnotneeded

Change-Id: Icee562986422d82506f43748ec968abd9d1d7146

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9714
Committed: https://git.mahara.org/mahara/mahara/commit/2a9211b3e2d8abe8699ed781f4fa52ec0b7cc68a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2a9211b3e2d8abe8699ed781f4fa52ec0b7cc68a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Apr 5 17:26:20 2019 +1300

Bug 1813987: removing helper functions to reorder cells in old layout

they won't be needed anymore

also remove use of properties
private $dirtyrows;
private $dirtycolumns;

Change-Id: I31e0c8296e72e9dd6b2381170864bdc52af766b7

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9551
Committed: https://git.mahara.org/mahara/mahara/commit/d45aed8d9200e409459ef8ba326c869c420494d3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d45aed8d9200e409459ef8ba326c869c420494d3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Feb 13 10:34:12 2019 +1300

Bug 1813987: Remove edit layout section

- also remove the layout pieform
and the custom layout javascript code

behatnotneeded

Change-Id: I3e2e2b3f09106dd2a341a40d178feca693194e64

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9556
Committed: https://git.mahara.org/mahara/mahara/commit/5f57b6023ede89e35c70ba2575626646c64c75b5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5f57b6023ede89e35c70ba2575626646c64c75b5
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Feb 13 16:18:34 2019 +1300

Bug 1813987: Remove 'addcolumn' functionality when editing a view

behatnotneeded

Change-Id: I99b248e03ffe5b23e622c46ce14765bdf1e47195

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9509
Committed: https://git.mahara.org/mahara/mahara/commit/2c861ec11807d1747d631a9ed568b985bb17bf17
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2c861ec11807d1747d631a9ed568b985bb17bf17
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jan 31 10:11:11 2019 +1300

Bug 1813987: Creating a new page with gristack layout

add a new block, place it anywhere in the grid, edit configuration
and delete it.

It will save it in the db on table block_instance_dimension
but not display it in view or edit mode yet

Also included a small fix in xmldb postgres class generator
to handle reserved words in getAlterFieldSQL function

Failing tests:

- most of them are failing when adding a new block to the page
because they expect to have a modal to choose the position
where to place block. That modal was removed for this patch but
there will be a similar one in patch:
https://reviews.mahara.org/#/c/9952
and those tests will be fixed there

- a few tests failed when they couldn't find text inside the
blocks because they are not expanded to fit the content yet.
This is added in patch:
https://reviews.mahara.org/#/c/9986
and they will be fixed there

behatnotneeded

Change-Id: If4521a6315f6e8cc5d88693f536946dace359288

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10398
Committed: https://git.mahara.org/mahara/mahara/commit/fa4085d5664f333f943ac0f58e3065d89137c10e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fa4085d5664f333f943ac0f58e3065d89137c10e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 4 12:09:43 2019 +1300

Bug 1813987: Tidying up some lastminute problems

like
- allow add block button to drop only inside the grid
- navigation block in collection to copy to other pages
- Smart evidence annotation feedback forms init tinymce
- showing the peer can see content message again
- allow copying of page with old layout

behatnotneeded

Change-Id: I3f552ce8f89125e9fd233513c855879aa7678048

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9329
Committed: https://git.mahara.org/mahara/mahara/commit/61acdaa6235bdc25388e13aeb1ba079605fac597
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 61acdaa6235bdc25388e13aeb1ba079605fac597
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Aug 10 16:57:51 2018 +1200

Bug 1813987: Adding gristack library

Adding gridstack and lodash library

behatnotneeded

Change-Id: I4143d4dcde2f34bce019d6da900253c61ae6e7a5

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10411

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10411
Committed: https://git.mahara.org/mahara/mahara/commit/02c6617dc28b9ddaea3fb9f433b08dc89832ae18
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 02c6617dc28b9ddaea3fb9f433b08dc89832ae18
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Oct 7 11:31:39 2019 +1300

Bug 1813987: resizing block when expandig collapsible inside block

fixes failed step in resume_page.feature
fixes in timeline view to expand a block to fit content

behatnotneeded

Change-Id: I1d187f338c0c36795efff40bbe8d9447b2d66124

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10448

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10450

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10436
Committed: https://git.mahara.org/mahara/mahara/commit/a8b9bfb186ed721ccca66d0578f1ae6ea408ba59
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a8b9bfb186ed721ccca66d0578f1ae6ea408ba59
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 11 11:14:08 2019 +1300

Bug 1813987: many fixes for gridstack

- set min height for grid only in edit page,
so it won't show a lot of empty space for pages
with few blocks
- make the journal block resize when expanding
content
- [FOR TESTING!!] resize the block everytime
a collapsible is expanded or collapsed
inside the block. Need to check what happens
to the layout structure of the blocks that
are under the block that resizes.

behatnotneeded

Change-Id: I64925c1cb518af30f569ac2bbf69baea6c07ec05

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10447
Committed: https://git.mahara.org/mahara/mahara/commit/0e7ce5c1c0377d82ec84ccc56f37bf9a39d3bc3e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0e7ce5c1c0377d82ec84ccc56f37bf9a39d3bc3e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 17 09:38:12 2019 +1300

Bug 1813987: removing static class in blocks

behatnotneeded

Change-Id: I137addd84013d4de46509cd83ce1e4eb376dd86c

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10444
Committed: https://git.mahara.org/mahara/mahara/commit/3ab2c9126d80db0aeb53095f20d7708a814dce03
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3ab2c9126d80db0aeb53095f20d7708a814dce03
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 15 17:23:29 2019 +1300

Bug 1813987:testing removing float mode in grid layout

- remove the dotted line around the blocks in
page view mode
- if there are retractable sections inside the block,
retracting/collapsing them will hide/show the section,
not the block
- set float: false in group homepage, dashboard, profile page

behatnotneeded
Change-Id: I6f3fbc75331f95fb5be9721520d19b99ca43e3d2

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10448
Committed: https://git.mahara.org/mahara/mahara/commit/6f2f9f8ff8de7f5d7745662a45e50015536bb5dc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6f2f9f8ff8de7f5d7745662a45e50015536bb5dc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 17 12:09:24 2019 +1300

Bug 1813987: saving accessibility option in view

- the accessibility value was not being saved
when creating a new page
- force 12 columns width for blocks when displaying
a page with accessible layout

behatnotneeded

Change-Id: Ide27bac7e471935e9625ce5caa821dca533ae672

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10450
Committed: https://git.mahara.org/mahara/mahara/commit/9e81132db3bf24df4db98b217aa2ab3abb0bff48
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9e81132db3bf24df4db98b217aa2ab3abb0bff48
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 18 13:55:54 2019 +1300

Bug 1813987: resizing wall/gallery block when content change

wall
- resize the block when adding a new post
- resize the block when the tinymce is changed
(menu expanded/textarea resized)

image gallery
- resize the block when the block has a slide show
and the image is changed

behatnotneeded

Change-Id: I7fe0624285443b6173d9bd5f5be488539f6da03d

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10466

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10466
Committed: https://git.mahara.org/mahara/mahara/commit/9a241ca8b302c0110b9d2ee62f37054c776104d3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9a241ca8b302c0110b9d2ee62f37054c776104d3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Oct 23 14:09:09 2019 +1300

Bug 1813987:droping a new block outside grid removes lastest block

behatnotneeded

Change-Id: I376d646fc034f88450c7bf0bbceee332692230ed

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10469

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10469
Committed: https://git.mahara.org/mahara/mahara/commit/d190004ce6dedb8a1f05ae57f008df48f2f9baca
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit d190004ce6dedb8a1f05ae57f008df48f2f9baca
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 11 11:14:08 2019 +1300

Bug 1813987: many fixes for gridstack

- set min height for grid only in edit page,
so it won't show a lot of empty space for pages
with few blocks
- make the journal block resize when expanding
content
- [FOR TESTING!!] resize the block everytime
a collapsible is expanded or collapsed
inside the block. Need to check what happens
to the layout structure of the blocks that
are under the block that resizes.

behatnotneeded

Change-Id: I64925c1cb518af30f569ac2bbf69baea6c07ec05
(cherry picked from commit a8b9bfb186ed721ccca66d0578f1ae6ea408ba59)

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10470

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10470
Committed: https://git.mahara.org/mahara/mahara/commit/3eb6196dbde3de675d0909146443c3d79aaba412
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 3eb6196dbde3de675d0909146443c3d79aaba412
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 17 09:38:12 2019 +1300

Bug 1813987: removing static class in blocks

behatnotneeded

Change-Id: I137addd84013d4de46509cd83ce1e4eb376dd86c

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10471

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10471
Committed: https://git.mahara.org/mahara/mahara/commit/1e43c06a496a82f3823efc9e4701ff9f2fd66bb8
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 1e43c06a496a82f3823efc9e4701ff9f2fd66bb8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 15 17:23:29 2019 +1300

Bug 1813987:testing removing float mode in grid layout

- remove the dotted line around the blocks in
page view mode
- if there are retractable sections inside the block,
retracting/collapsing them will hide/show the section,
not the block
- set float: false in group homepage, dashboard, profile page

behatnotneeded
Change-Id: I6f3fbc75331f95fb5be9721520d19b99ca43e3d2

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10472

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10472
Committed: https://git.mahara.org/mahara/mahara/commit/712cd9dca39b15d506bf1d8c4d6794e1bd8192fe
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 712cd9dca39b15d506bf1d8c4d6794e1bd8192fe
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 17 12:09:24 2019 +1300

Bug 1813987: saving accessibility option in view

- the accessibility value was not being saved
when creating a new page
- force 12 columns width for blocks when displaying
a page with accessible layout

behatnotneeded

Change-Id: Ide27bac7e471935e9625ce5caa821dca533ae672
(cherry picked from commit 6f2f9f8ff8de7f5d7745662a45e50015536bb5dc)

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10473

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10473
Committed: https://git.mahara.org/mahara/mahara/commit/d2bf336b58e6167fa75594039b6ee4811710f1dc
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit d2bf336b58e6167fa75594039b6ee4811710f1dc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 18 13:55:54 2019 +1300

Bug 1813987: resizing wall/gallery block when content change

wall
- resize the block when adding a new post
- resize the block when the tinymce is changed
(menu expanded/textarea resized)

image gallery
- resize the block when the block has a slide show
and the image is changed

behatnotneeded

Change-Id: I7fe0624285443b6173d9bd5f5be488539f6da03d
(cherry picked from commit 9e81132db3bf24df4db98b217aa2ab3abb0bff48)

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10475

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10475
Committed: https://git.mahara.org/mahara/mahara/commit/5766ea5a40b5d9de2190f885020fea1ec3b93401
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 5766ea5a40b5d9de2190f885020fea1ec3b93401
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Oct 23 14:09:09 2019 +1300

Bug 1813987:droping a new block outside grid removes lastest block

behatnotneeded

Change-Id: I376d646fc034f88450c7bf0bbceee332692230ed
(cherry picked from commit 9a241ca8b302c0110b9d2ee62f37054c776104d3)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10505

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10505
Committed: https://git.mahara.org/mahara/mahara/commit/9b3a9303cc8d314214c16dd2d7a78f771ee53f99
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9b3a9303cc8d314214c16dd2d7a78f771ee53f99
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 29 10:20:05 2019 +1300

Bug 1813987: gridstack resizing fixes

- manual block resize: round value to closest column/row
- set min height for a block so automatic resize won't make
a block smaller than the height the user selected on view edit
- no float grid: save the new position of all blocks
when gridstack moves them to fill empty spaces
- no need to consider the horizontal margin when
setting the column number for a block
- don't set min-height for collapsible blocks on display

behatnotneeded
Change-Id: I4a890a83ed76df523a2904a9776cf7f1076d3cb2

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10508

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10508
Committed: https://git.mahara.org/mahara/mahara/commit/f83b4c6b148a3e9e66916cd15428da9c6ec08261
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit f83b4c6b148a3e9e66916cd15428da9c6ec08261
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Oct 29 10:20:05 2019 +1300

Bug 1813987: gridstack resizing fixes

- manual block resize: round value to closest column/row
- set min height for a block so automatic resize won't make
a block smaller than the height the user selected on view edit
- no float grid: save the new position of all blocks
when gridstack moves them to fill empty spaces
- no need to consider the horizontal margin when
setting the column number for a block
- don't set min-height for collapsible blocks on display

behatnotneeded
Change-Id: I4a890a83ed76df523a2904a9776cf7f1076d3cb2
(cherry picked from commit 9b3a9303cc8d314214c16dd2d7a78f771ee53f99)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10509

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10509
Committed: https://git.mahara.org/mahara/mahara/commit/f7632dbe9bd37acb8b1d775f88f66d98b7880a6b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit f7632dbe9bd37acb8b1d775f88f66d98b7880a6b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Oct 30 14:33:18 2019 +1300

Bug 1813987: gridstack initializing variable in the right place

behatnotneeded

Change-Id: Ie32725e6933cb3e572eae209db0bfbe1e6959fb4

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10511

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10511
Committed: https://git.mahara.org/mahara/mahara/commit/0a8454f922ab37b8bb7b1a322c9c5098ba8251ea
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 0a8454f922ab37b8bb7b1a322c9c5098ba8251ea
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Oct 30 14:33:18 2019 +1300

Bug 1813987: gridstack initializing variable in the right place

behatnotneeded

Change-Id: Ie32725e6933cb3e572eae209db0bfbe1e6959fb4
(cherry picked from commit f7632dbe9bd37acb8b1d775f88f66d98b7880a6b)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10512