dahdi-linux 1:2.11.1~dfsg-1ubuntu4 ADT test failure with linux 5.0.0-1.2

[Seth Forshee]

[Impact]

Currently the DKMS package fails to install on supported custom
kernels that are based on 5.0.

[Test Case]

Install the dahdi-dkms package with the 5.0 unstable kernel. The
package installation should proceed without any errors.

[Regression Potential]

Although new patches were added, the regression risk is very low since
the new changes are conditionally compiled based on the kernel
version.

Besides that, the new package was tested with the following kernels in
an amd64 environment:

- linux-generic 5.0
- linux-generic 4.19

[Original Description]

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/d/dahdi-linux/20190123_162957_2d0d8@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/d/dahdi-linux/20190123_163457_2d0d8@/log.gz

[Marcelo Cerri (mhcerri)]

Debdiff attached.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dahdi-linux - 1:2.11.1~dfsg-1ubuntu5

---------------
dahdi-linux (1:2.11.1~dfsg-1ubuntu5) disco; urgency=medium

  * Linux 5.0 compatibility (LP: #1813058)
    - d/p/kernel-compat-5.0.patch

 -- Marcelo Henrique Cerri <email address hidden> Thu, 07 Feb 2019 10:15:57 -0200

[Connor Kuehl (connork)]

We're experiencing this on bionic/linux-hwe-edge:

    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/d/dahdi-linux/20190503_033019_11103@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/i386/d/dahdi-linux/20190503_033027_11103@/log.gz

To fix this, I've backported Marcelo's patch from comment #1. No context adjustments were required.

Testing:

- Create a Bionic 18.04 VM
- Enable the -proposed repository and/or install the bionic linux hwe edge .debs from here: https://launchpad.net/~canonical-kernel-team/+archive/ubuntu/ppa/+packages?field.name_filter=linux-hwe-edge&field.status_filter=published&field.series_filter=bionic
- Install dahdi-dkms ("sudo apt install dahdi-dkms")
- Confirm installation fails for the 5.0 kernel because the DKMS module cannot be compiled.
- Remove the failed install "sudo apt remove dahdi-dkms"
- Download the sources "pull-lp-source dahdi-linux bionic"
- Apply the debdiff attached to this comment "debdiff-apply < path-to-this-patch.debdiff
- Build the package "debuild -uc -us"
- Install the .deb generated in the parent directory "sudo dpkg -i ../path-to-built.deb"
- Confirm installation did not fail, you can even see if it's active with "sudo dkms status"

[Łukasz Zemczak (sil2100)]

Hello Seth, or anyone else affected,

Accepted dahdi-linux into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dahdi-linux/1:2.11.1~dfsg-1ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Stefan Bader (smb)]

Building failed for 2.11.1~dfsg-1ubuntu4 and kernel 5.0.0-23-generic:

/etc/kernel/header_postinst.d/dkms:
 * dkms: running auto installation service for kernel 5.0.0-23-generic

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area...
(make modules KVERS=5.0.0-23-generic MODULES_EXTRA='dahdi_dummy dahdi_echocan_oslec'; make KVERS=5.0.0-23-generic; make KVERS=5.0.0-23-generic firmware-loaders; echo : > drivers/dahdi/vpmadt032_loader/.vpmadt032_x86_32.o.cmd; echo : > drivers/dahdi/vpmadt032_loader/.vpmadt032_x86_64.o.cmd; make KVERS=5.0.0-23-generic)......(bad exit status: 2)
Error! Bad return status for module build on kernel: 5.0.0-23-generic (x86_64)
Consult /var/lib/dkms/dahdi/2.11.1~dfsg-1ubuntu4/build/make.log for more information.

Builds successfull with 2.11.1~dfsg-1ubuntu4.1:

dahdi, 2.11.1~dfsg-1ubuntu4.1, 4.15.0-55-generic, x86_64: installed
dahdi, 2.11.1~dfsg-1ubuntu4.1, 5.0.0-23-generic, x86_64: installed

[Launchpad Janitor (janitor)]

This bug was fixed in the package dahdi-linux - 1:2.11.1~dfsg-1ubuntu4.1

---------------
dahdi-linux (1:2.11.1~dfsg-1ubuntu4.1) bionic; urgency=medium

  * Fix build for Linux kernel 5.0 (LP: #1813058)
    - debian/patches/kernel-compat-5.0.patch

 -- Connor Kuehl <email address hidden> Fri, 10 May 2019 15:27:49 -0700

[Andy Whitcroft (apw)]

The verification of the Stable Release Update for dahdi-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.