need to upgrade Font Awesome library from 4.7.0 to 5.X

[Cecilia Vela Gurovic]

need to upgrade Font Awesome library from 4.7.0 to 5.6.3

[Cecilia Vela Gurovic (ceciliavg)]

There are a lot of changes from v4 to v5, it's not as simple as changing the lib files.

Mainly they ad a new css class to define is the icon is solid, light or regular, while in v4 it's part of the main icon class. They have also changed many icon names.

https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4

This upgrade is not a simple task and there are no security patches yet, I think we can leave it for 19.10

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9968

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9975

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9981

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9984

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9987

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9988

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9994

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10005

[Rebecca Blundell (rjb-dev)]

Notes for testing:

All of the icons on the site are now coming from the Fontawesome v5 library (https://fontawesome.com/icons?d=gallery).
This is tricky to test comprehensively as the icons really are present in all areas of the site.

To test:
1. First view the icons tab of the styleguide (mahara/theme/styleguide.php) in both master and the patch side by side. Look for missing icons in the patch and differences between master and the patch where the icon in the patch seems inverted or completely different to the master icon.

2. The icons have changed everywhere, so this is not an exhaustive list, but we should check some of the more specific cases where things needed to be updated:

Navigation:
Check all the menus contain corrects icons. (Note you may have to clear the caches on the admin overview page for the menu changes to take effect.)

Main Menu

Pages and Collections:
1. As well as the main icons, check the drop-down menu items from the cards.
2. Note that the block-chooser for a page is not currently displaying icons. This is not part of the test as it is being removed
3. Share a page with another user.
4. Log in as the other user and go to the page. Click on the 3 dots and then toggle the 'Add page to watchlist' option to confirm the icon flicks between eye and eye-slash.

Files:
1. Upload an image. Choose edit. Confirm the rotate icon appears.

Journals:
1. Confirm the calendar icons appear on journal entries.

Plans:
1. Checked boxes appear on completed items.
2. If you add the plan to a page block, an empty box appears on pending items.

People:
1. Check 'Remove from friends' icon is a person & x.

Groups:
1. Set up a group with these settings:
 Open - yes
 Recommendations - yes
 There need to be some site users who are not members of the group.
2. Log in as a user who is a member of the group and go to the group admin page. You should see a lightbulb icon on the 'Recommend to friends' button.
3. Compare this and the other icons on the page with a similar page on master.

Admin Menu

Institutions -> Legal
1. Add a couple of privacy statements.
2. Confirm that the most recent has a pencil and the others have an eye icon.

Extensions -> SmartEvidence
1. Follow the settings tab for a framework and check that the icons display correctly.
2. Add a framework to a collection.
3. Confirm that on the collection card drop-down there is a clipboard icon on the framework.
4. Add annotations to the framework and confirm the correct icons display on the module/framework/matrix page.

3. Finally click through the pages and look for anywhere icons are missing or seem wrong.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10101

[Steven (stevens-q)]

TITLE: User menu Profile pictures link is missing icon

BUG SUMMARY: User menu "Profile pictures" link is missing icon

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User is logged in

TEST STEPS:
------------------------
1) User click on the User menu

EXPECTED RESULT: Profile pictures link should display an icon

ACTUAL RESULT: Profile pictures link displays a rectangle icon - this icon is incorrect

[Steven (stevens-q)]

TITLE: My Tags page does not display icon for journal entry that have a tag

BUG SUMMARY: My Tags page does not display icon for journal entry that have a tag

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User is logged in
2) Journal entry is tagged

TEST STEPS:
------------------------
1) User browse to the Tags page

EXPECTED RESULT: All content types should have an icon displayed to the left of the content title

ACTUAL RESULT: No icon is displayed for the journal content page that is listed on page

[Steven (stevens-q)]

TITLE: Site options page, Account settings section displays the incorrect icon

BUG SUMMARY: Site options page, Account settings section displays the incorrect icon

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User is logged into site

TEST STEPS:
------------------------
1) User browse to Admin menu > Site settings > Site options

EXPECTED RESULT: New iconor clock icon (old icon) should be displayed

ACTUAL RESULT: rectangle icon is displayed

[Steven (stevens-q)]

TITLE: Legal page when viewed when not logged in is not displayed with correct icon

BUG SUMMARY: Legal page when viewed when not logged in is not displayed with correct icon

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User is not logged in

TEST STEPS:
------------------------
1) User click the legal link at the bottom of the Mahara log in page

EXPECTED RESULT: The new Gavel icon should be displayed on the legal page

ACTUAL RESULT: The icon displayed is the old umbrella icon

[Steven (stevens-q)]

TITLE: Portfolio Page in Edit mode does not display most icons for the Content type chooser (located left side of page)

BUG SUMMARY: Portfolio Page in Edit mode does not display most icons for the Content type chooser (located left side of page)

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User is logged into site

TEST STEPS:
------------------------
1) User create or edit a portfolio page
2) view the content type block located on the left side of the page

EXPECTED RESULT: all icons are displayed for each of the content types available

ACTUAL RESULT: most icons are missing for this block

[Steven (stevens-q)]

TITLE: Admin overview page displays incorrect icon for Web services and Manage groups sections

BUG SUMMARY: Admin overview page displays incorrect icon for Web services and Manage groups sections

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User is logged into site

TEST STEPS:
------------------------
1) User browse to Admin overview page

EXPECTED RESULT:
1) The icon for the Web services section of the page should have the same icon as is displayed in the Admin menu
2) The icon for the Manage groups section of the page should have the same icon as is displayed in the Admin menu

ACTUAL RESULT: Displays a puzzle peice for Web services and displays old icon for manage groups

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10101
Committed: https://git.mahara.org/mahara/mahara/commit/045ab473849444ec31e633b0055b6c38528acab1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 045ab473849444ec31e633b0055b6c38528acab1
Author: Robert Lyon <email address hidden>
Date: Wed Jun 19 12:56:35 2019 +1200

Bug 1811904: Updating the README for fontawesome version 5

behatnotneeded

Change-Id: I9395aaa9b483170eae54e71c0e0bd34c35017870
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9988
Committed: https://git.mahara.org/mahara/mahara/commit/4b16a73fad28ffce634a5281b2c5656845ac69c5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4b16a73fad28ffce634a5281b2c5656845ac69c5
Author: Rebecca Blundell <email address hidden>
Date: Fri May 10 13:32:00 2019 +1200

Bug 1811904: Fontawesome - more name changes 2

icon-envelope-o -> icon-regular icon-envelope
icon-exchange -> icon-exchange-alt
icon-file-image-o -> icon-regular icon-file-image
icon-id-badge -> icon-regular icon-id-badge
icon-id-card-o -> icon-regular icon-id-card
icon-clone -> icon-regular icon-clone
icon-sign-out -> icon-sign-out-alt

behatnotneeded

Change-Id: I6f07f3b9c14184e98e44cd1b5568766d3fa9221a

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9987
Committed: https://git.mahara.org/mahara/mahara/commit/7db2c719a27b3ef963274c81bc1145c3669f6c9d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7db2c719a27b3ef963274c81bc1145c3669f6c9d
Author: Rebecca Blundell <email address hidden>
Date: Thu May 9 18:50:20 2019 +1200

Bug 1811904: Fontawesome: more name changes

icon-arrows -> icon-arrows-alt
icon-shield -> icon-shield-alt
icon-refresh -> icon-sync-alt
icon-clock-o -> icon-clock
icon-pie-chart -> icon-chart-pie
icon-area-chart -> icon-chart-area
icon-commenting-o -> icon-comment-dots
icon-arrows -> icon-arrows-alt
icon-question-circle-o -> icon-question-circle

behatnotneeded

Change-Id: I4fb3feebc11cc335f5dde05cc6e45c50b29359a6

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10005
Committed: https://git.mahara.org/mahara/mahara/commit/c3479dc655284801802add1848d6c6fcb7be41f8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c3479dc655284801802add1848d6c6fcb7be41f8
Author: Rebecca Blundell <email address hidden>
Date: Tue May 14 14:10:00 2019 +1200

Bug 1811904: Fontawesome - final name changes

icon-clipboard -> icon-clipboard-check
icon-eye -> icon-regular icon-eye
icon-eye-slash -> icon-regular icon-eye-slash
icon-file-archive-o -> icon-regular
icon-comments-o -> icon-comments
icon-external-link -> icon-external-link-alt
icon-tachometer -> icon-tachometer-alt
icon-rotate-right -> icon-redo
icon-file-archive-o -> icon-file-archive
icon-comments-o -> icon-comments
icon-send -> icon-paper-plane
icon-lightbulb-o -> icon-regular icon-lightbulb
icon-code-fork -> icon-code-branch - changed versioning to
'history' icon
icon-file-o -> icon-regular icon-file

also changed some icons to new ones
used text-align, width and margin-right to centre list items.

behatnotneeded

Change-Id: I4d27e450a281dc49716d97de309a3c99b89a0bc1

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9994
Committed: https://git.mahara.org/mahara/mahara/commit/e84165b0292037a851d05a3673f6060242b0b66a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e84165b0292037a851d05a3673f6060242b0b66a
Author: Rebecca Blundell <email address hidden>
Date: Mon May 13 16:52:01 2019 +1200

Bug 1811904: Fontawesome - yet more name changes

icon-calendar -> icon-regular icon-calendar-alt
icon-check-square-o -> icon-regular icon-check-square
icon-square-o -> icon-regular icon-square
icon-circle-o -> icon-regular icon-circle
icon-legal -> icon-gavel
icon-level-up -> icon-level-up-alt
icon-long-arrow-down-> icon-long-arrow-alt-down
long-arrow-left -> icon-long-arrow-alt-left
long-arrow-right -> icon-long-arrow-alt-right
long-arrow-up -> icon-long-arrow-alt-up

icon-remove -> icon-times || icon-user-times
(times is the 'x'used elsewhere, user-times is the 'x' next to a profile person.
Remove has been removed so I have deleted it from the styleguide)

icon-level-up -> icon-level-up-alt
icon-heart-o -> icon-regular icon-heart
icon-arrows -> icon-arrows-alt

icon-sign-in ->icon-sign-in-alt

Change-Id: Ia2cd81ea24119a7d0fec3000af1eaf2571a2a62b

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9984
Committed: https://git.mahara.org/mahara/mahara/commit/7b9529647e8cfd4243762599fac5dbd7ae9664d5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7b9529647e8cfd4243762599fac5dbd7ae9664d5
Author: Rebecca Blundell <email address hidden>
Date: Thu May 9 11:30:14 2019 +1200

Bug 1811904: Fontawesome - Name changes

new default for fontawesome is 'solid',
where we are using a different class (regular or brand),
we need to add these.

also confirming that where the icon name has changed, we've
picked that up.

Where there's a choice of icon, I've kept it as close to what we
currently have as possible.
All free icons can be seen here:
https://fontawesome.com/icons?d=gallery&m=free

Name changes:
icon-trash-alt -> icon-trash
icon-pencil -> icon-pencil-alt
icon-unlock-alt -> icon-unlock
icon-files-o -> icon-regular icon-copy
icon-pencil-square -> icon-regular icon-edit
icon-file-text -> icon-file-alt || icon-regular icon-file-alt
icon-image -> icon-regular icon-image

behatnotneeded

Change-Id: I34646a6857f6cf54dc39572f5a66c07da4f4c0e2

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9975
Committed: https://git.mahara.org/mahara/mahara/commit/3b8810105c03a38783bd416840fade56649f3120
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3b8810105c03a38783bd416840fade56649f3120
Author: Rebecca Blundell <email address hidden>
Date: Wed May 8 12:42:39 2019 +1200

Bug 1811904: Fontawesome - change variable names in sass files

- changing existing sass varaibles to the new fa 5 names
- changing css prefix to icon, which we use
- adding css to over-ride fa classes with our own

behatnotneeded

Change-Id: Ic4908d800c702b2f47f6a0406d0847e4d507d34b

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9968
Committed: https://git.mahara.org/mahara/mahara/commit/90e4d5d7d9eb475fc3550a3d2556134193567263
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 90e4d5d7d9eb475fc3550a3d2556134193567263
Author: Rebecca Blundell <email address hidden>
Date: Tue May 7 12:59:24 2019 +1200

Bug 1811904: Add fontawesome 5 files

remove version 4 font files and add version 5

behatnotneeded

Change-Id: Ia49cab8290c9c7bd5aa934cba7460cf9f5962d52

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10150

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10150
Committed: https://git.mahara.org/mahara/mahara/commit/e2901f9c7c7f9edc1729cef5d34fbbe71bb8ce0d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e2901f9c7c7f9edc1729cef5d34fbbe71bb8ce0d
Author: Robert Lyon <email address hidden>
Date: Tue Jul 9 15:51:13 2019 +1200

Bug 1811904: Include new fontawesome @font-face files

behatnotneeded

Change-Id: Ib79d283dfda2731f46848ab6dc773e70241d435e
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10152

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10152
Committed: https://git.mahara.org/mahara/mahara/commit/0a9c93569d03777a7397ef9160969b7afd9fb721
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0a9c93569d03777a7397ef9160969b7afd9fb721
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Wed Jul 10 22:44:59 2019 +1200

Bug 1811904: Font Awesome icon adjustments

A few icons required adjusting to use only
free icons. Additionally, icons in the
card header in the "Primary School" theme
were changed or added in the first place.

Needed to update the card icons to use the correct font awesome family

behatnotneeded

Change-Id: Ief8f4b4393b1becfb18a8c39d3ef6b8966bbe9eb

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10237

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10237
Committed: https://git.mahara.org/mahara/mahara/commit/23f135e6aaee9f75859cc41c76c20edf62d5bbe6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 23f135e6aaee9f75859cc41c76c20edf62d5bbe6
Author: Robert Lyon <email address hidden>
Date: Sun Aug 4 14:06:29 2019 +1200

Bug 1811904: Font Awesome icon profile page fix

Change-Id: Ic07daf766898640f1e986f862b24a7de803ac326
Signed-off-by: Robert Lyon <email address hidden>