blacklist for cloud edge kernel is not working

Bug #1806799 reported by Po-Hsu Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-kernel-tests
Fix Released
High
Po-Hsu Lin

Bug Description

The tests blacklisted for cloud edge kernels are still getting executed, the reason is because we're using the following logic for checking blacklist files:

        if s.blacklisted(test, s.request['flavour']):
            cinfo('%s (blacklisted - flavour)' % test, 'red')
            continue

Take aws for example it will use these to check for a blacklist.aws file in the test dir:
    def blacklisted(s, test, value):
        retval = False
        bl = os.path.join(s.autotest_tests_root, test, 'blacklist.%s' % value)
        if os.path.exists(bl):
            retval = True

The flavour here for edge kernels passed from the test request has become:
    "flavour": "aws-edge",

But the blacklist file for this is blacklist.aws. That's why it's not working.

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Although the azure-edge kernel might have the same issue, but we don't have any test that's blacklisted with Azure.

So the only affected one is the AWS-edge kernel.

Changed in ubuntu-kernel-tests:
status: New → In Progress
importance: Undecided → High
Po-Hsu Lin (cypressyew)
Changed in ubuntu-kernel-tests:
assignee: nobody → Po-Hsu Lin (cypressyew)
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Patch sent for CKCT.

For the runner and dep8-runner in kernel-testing, it's using the flavour obtained from:
    platform.release().split('-')

And it's not taking test request for clouds, so it can be skipped.

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

quota_smoke_test won't get triggered now.

Changed in ubuntu-kernel-tests:
status: In Progress → Fix Released
Revision history for this message
Sean Feole (sfeole) wrote : Re: [Bug 1806799] Re: blacklist for cloud edge kernel is not working

thx!, commit# 6762c82dcc9f98219108f2348fd0d37928db2da5

On Mon, Dec 10, 2018 at 10:01 PM Po-Hsu Lin <email address hidden>
wrote:

> quota_smoke_test won't get triggered now.
>
> ** Changed in: ubuntu-kernel-tests
> Status: In Progress => Fix Released
>
> --
> You received this bug notification because you are a member of Canonical
> Kernel Team, which is subscribed to ubuntu-kernel-tests.
> https://bugs.launchpad.net/bugs/1806799
>
> Title:
> blacklist for cloud edge kernel is not working
>
> Status in ubuntu-kernel-tests:
> Fix Released
>
> Bug description:
> The tests blacklisted for cloud edge kernels are still getting
> executed, the reason is because we're using the following logic for
> checking blacklist files:
>
> if s.blacklisted(test, s.request['flavour']):
> cinfo('%s (blacklisted - flavour)' % test, 'red')
> continue
>
> Take aws for example it will use these to check for a blacklist.aws file
> in the test dir:
> def blacklisted(s, test, value):
> retval = False
> bl = os.path.join(s.autotest_tests_root, test, 'blacklist.%s' %
> value)
> if os.path.exists(bl):
> retval = True
>
> The flavour here for edge kernels passed from the test request has
> become:
> "flavour": "aws-edge",
>
> But the blacklist file for this is blacklist.aws. That's why it's not
> working.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1806799/+subscriptions
>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.