Merge qtdmm 0.8.12-1 from Debian(Unstable)

[Stefan Ebner]

Binary package hint: qtdmm

Debian changelog's entries since latest Ubuntu one:

 qtdmm (0.8.12-1) unstable; urgency=low

   * New upstream version (Closes: #417508).
     - Added PeakTech 4015A (Jochen Puchalla)
     - Added Tenma 72-7745 (Laurent Perez)
     - Bugfix McVoice M-980T (Erik Hobel)
     - Added Digitech QM1462 (Peter Halasz)
     - Added Digitek INO2513
     - Added Raio Shack 22-812 (Bruce Lilly)
     - Corrected typo in dmmgraph (Erik Hobel)

 -- Steffen Moeller <email address hidden> Tue, 25 Dec 2007 18:51:33 +0100

Remaining changes to be merged:

    - Install desktop file and icon in correct path.
    - Some .desktop fixes.
  * Drop deprecated encoding field and categories from .desktop.

[Andrea Veri (av)]

Remember to un-assign from you when a debdiff is attached to the report. Thanks.

[Andrea Veri (av)]

Something seems to be wrong here:

1) Standards-Version bump is not documented in your changelog entry. Plus it's better waiting this change directly from qtdmm's Debian Maintainer instead of doing it on your own.
2) the change you made in debian/rules about distclean is not documented, would you mind adding it?
- -$(MAKE) distclean
+ [ ! -f Makefile ] || $(MAKE) distclean
3) Why "* Drop deprecated encoding field and categories from .desktop." still uses "*"? actually we cannot consider that change as *new* but as a remaining one instead.

Apart from them the debdiff looks fine, marking the bug as incomplete and re-assigning to you again.

[Andrea Veri (av)]

Looks fine, just two more things:

1) I guess you can include "Drop deprecated encoding field and categories from .desktop." into "Some .desktop fixes." by writing something like "- Added to the .desktop file some fixes and cleaned it up a bit"
2) it seems you've missed to document the Maintainer change made in debian/control

Would you mind fixing them?

[Stefan Ebner (sebner)]

Hopefully last try ^^

[Launchpad Janitor (janitor)]

This bug was fixed in the package qtdmm - 0.8.12-1ubuntu1

---------------
qtdmm (0.8.12-1ubuntu1) hardy; urgency=low

  * Merge from debian unstable (LP: #180124). remaining changes:
    - Install desktop file and icon in correct path.
    - Added to the .desktop file some fixes and cleaned it up a bit
    - fixing a lintian warning about a bad use of distclean by using
      [ ! -f Makefile ] || $(MAKE) instead of -$(MAKE) distclean.
    - Modify Maintainer value to match Debian-Maintainer-Field Spec

qtdmm (0.8.12-1) unstable; urgency=low

  * New upstream version (Closes: #417508).
    - Added PeakTech 4015A (Jochen Puchalla)
    - Added Tenma 72-7745 (Laurent Perez)
    - Bugfix McVoice M-980T (Erik Hobel)
    - Added Digitech QM1462 (Peter Halasz)
    - Added Digitek INO2513
    - Added Raio Shack 22-812 (Bruce Lilly)
    - Corrected typo in dmmgraph (Erik Hobel)

 -- Stefan Ebner <email address hidden> Thu, 3 Jan 2008 18:27:39 +0100