Make reset_devices parameter default for kdump
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
makedumpfile (Ubuntu) |
Fix Released
|
High
|
Guilherme G. Piccoli | ||
Trusty |
Won't Fix
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
High
|
Guilherme G. Piccoli | ||
Bionic |
Fix Released
|
High
|
Guilherme G. Piccoli | ||
Cosmic |
Won't Fix
|
Undecided
|
Unassigned | ||
Disco |
Won't Fix
|
Undecided
|
Unassigned | ||
Eoan |
Fix Released
|
High
|
Guilherme G. Piccoli | ||
Focal |
Fix Released
|
High
|
Guilherme G. Piccoli |
Bug Description
[Impact]
* Kdump does not configure by default the crash kernel to perform a device reset by default, by passing the "reset_devices" parameter.
* Kernel has the "reset_devices" parameter that drivers can opt-in, and perform special activity in case this parameter is parsed from command-line. For example, in kdump kernels it hints the drivers that they are booting from a non-healthy condition and needs to issue some form of reset to the adapter, like clearing DMA mapping in their firmware for example. Users currently (kernel v5.5-rc2) are: aacraid, hpsa, ipr, megaraid_sas, mpt3sas, smartpqi, xenbus.
This should be enabled by default in the kdump config file to be added in the kdump kernel command-line for all versions.
[Test Case]
1) Deploy a Bionic VM e.g. with uvt-kvm
2) Install the kdump-tools package
3) Run `kdump-config test`and check for the 'reset_devices' parameter:
$ kdump-config test
...
kexec command to be used:
/sbin/kexec -p --command-
[Regression Potential]
The regression potential is low, since it doesn't need any changes in makedumpfile code and we're only adding a parameter on the crash kernel command-line. The risks are related with bad behavior with the kernel when using "reset_devices", like if the driver has bugs in this path. It's considered safer to have the option (and this way prevent problems for booting a unhealthy kernel with potential stuck DMAs in the devices) than not having it.
Changed in makedumpfile (Ubuntu Cosmic): | |
importance: | Undecided → High |
Changed in makedumpfile (Ubuntu Bionic): | |
importance: | Undecided → High |
Changed in makedumpfile (Ubuntu Xenial): | |
importance: | Undecided → High |
Changed in makedumpfile (Ubuntu Trusty): | |
importance: | Undecided → High |
assignee: | nobody → Guilherme G. Piccoli (gpiccoli) |
Changed in makedumpfile (Ubuntu Trusty): | |
assignee: | Guilherme G. Piccoli (gpiccoli) → Heitor R. Alves de Siqueira (halves) |
Changed in makedumpfile (Ubuntu Xenial): | |
assignee: | nobody → Heitor R. Alves de Siqueira (halves) |
Changed in makedumpfile (Ubuntu Bionic): | |
assignee: | nobody → Heitor R. Alves de Siqueira (halves) |
Changed in makedumpfile (Ubuntu Cosmic): | |
assignee: | nobody → Heitor R. Alves de Siqueira (halves) |
Changed in makedumpfile (Ubuntu Disco): | |
assignee: | Mauricio Faria de Oliveira (mfo) → Heitor R. Alves de Siqueira (halves) |
Changed in makedumpfile (Ubuntu Cosmic): | |
status: | New → Confirmed |
Changed in makedumpfile (Ubuntu Bionic): | |
status: | New → Confirmed |
Changed in makedumpfile (Ubuntu Xenial): | |
status: | New → Confirmed |
Changed in makedumpfile (Ubuntu Trusty): | |
status: | New → Confirmed |
description: | updated |
tags: | removed: sts |
tags: | added: seg |
Changed in makedumpfile (Ubuntu): | |
assignee: | Heitor Alves de Siqueira (halves) → Guilherme G. Piccoli (gpiccoli) |
Changed in makedumpfile (Ubuntu Xenial): | |
assignee: | Heitor Alves de Siqueira (halves) → Guilherme G. Piccoli (gpiccoli) |
Changed in makedumpfile (Ubuntu Bionic): | |
assignee: | Heitor Alves de Siqueira (halves) → Guilherme G. Piccoli (gpiccoli) |
Changed in makedumpfile (Ubuntu Disco): | |
assignee: | Heitor Alves de Siqueira (halves) → Guilherme G. Piccoli (gpiccoli) |
Changed in makedumpfile (Ubuntu Trusty): | |
status: | Confirmed → Won't Fix |
Changed in makedumpfile (Ubuntu Cosmic): | |
assignee: | Heitor Alves de Siqueira (halves) → Guilherme G. Piccoli (gpiccoli) |
Changed in makedumpfile (Ubuntu Trusty): | |
assignee: | Heitor Alves de Siqueira (halves) → Guilherme G. Piccoli (gpiccoli) |
summary: |
- Make the reset_devices parameter default for kdump kernels + Make reset_devices parameter default for kdump and decouple kdump + systemd service from the KDUMP_CMDLINE_APPEND |
description: | updated |
Changed in makedumpfile (Ubuntu Cosmic): | |
status: | Confirmed → Won't Fix |
Changed in makedumpfile (Ubuntu Eoan): | |
status: | In Progress → Confirmed |
Changed in makedumpfile (Ubuntu Focal): | |
status: | In Progress → Confirmed |
Changed in makedumpfile (Ubuntu Disco): | |
status: | Confirmed → Won't Fix |
Changed in makedumpfile (Ubuntu Focal): | |
status: | Confirmed → In Progress |
Changed in makedumpfile (Ubuntu Eoan): | |
status: | Confirmed → In Progress |
Changed in makedumpfile (Ubuntu Bionic): | |
status: | Confirmed → In Progress |
Changed in makedumpfile (Ubuntu Xenial): | |
status: | Confirmed → In Progress |
Changed in makedumpfile (Ubuntu Disco): | |
status: | Won't Fix → In Progress |
summary: |
- Make reset_devices parameter default for kdump and decouple kdump - systemd service from the KDUMP_CMDLINE_APPEND + Make reset_devices parameter default for kdump |
description: | updated |
Changed in makedumpfile (Ubuntu Disco): | |
status: | In Progress → Won't Fix |
importance: | High → Undecided |
assignee: | Guilherme G. Piccoli (gpiccoli) → nobody |
Changed in makedumpfile (Ubuntu Cosmic): | |
importance: | High → Undecided |
assignee: | Guilherme G. Piccoli (gpiccoli) → nobody |
Debdiffs for this bug were attached to LP#1800562