Page and peer instructions are not exported properly in HTML and Leap2A

[Kristina Hoeppner]

When a portfolio is exported that has page instructions, they do not appear in the HTML or Leap2A export.

Since they are part of the portfolio, they should be exported.

[Steven (stevens-q)]

Peer assessment blocks do not display instructions for both Leap2a of html page exports when viewing the displayed page. However when a user has Imported a Leap2a page with Peer assessment block and edits the newly imported page the user is able to see the instructions in the modal window

[Robert Lyon (robertl-9)]

I see page instructions in HTML export and in Leap2A export

Also when importing the Leap2A to another user the page is created with instructions

[Kristina Hoeppner (kris-hoeppner)]

Tested this with 19.04RC1

1. Page instructions appear in HTML, including an embedded image.
2. Page instructions appear in Leap2A but without the embedded image.
3. Peer assessment instructions do not appear in the HTML export (see portfolio_html_peer_assessment_completed.zip).
4. Peer assessment instruction do appear when the Leap2A export is imported again and also bring an image along.
4. When trying to import a portfolio with a peer assessment block filled in (portfolio_leap2a_peer_assessment_completed.zip), the following error message occurs:

[WAR] d7 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
Call stack (most recent first):

    log_message("Array to string conversion", 8, true, true, "/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45) at /home/kristina/code/mahara/htdocs/lib/errors.php:520
    error(8, "Array to string conversion", "/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45, array(size 7)) at /home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:45
    ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: null value in column "block" violates not-...", "INSERT INTO "artefact_peer_assessment" ("assessmen...", array(size 3), object(ADODB_postgres8)) at /home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:80
    adodb_throw("postgres8", "adodb_throw", -1, "ERROR: null value in column "block" violates not-...", "INSERT INTO "artefact_peer_assessment" ("assessmen...", array(size 3), object(ADODB_postgres8)) at /home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:310
    ADODB_TransMonitor("postgres8", "adodb_throw", -1, "ERROR: null value in column "block" violates not-...", "INSERT INTO "artefact_peer_assessment" ("assessmen...", array(size 3), object(ADODB_postgres8)) at /home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1281
    ADOConnection->_Execute("INSERT INTO "artefact_peer_assessment" ("assessmen...", array(size 3)) at /home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1241
    ADOConnection->Execute("INSERT INTO "artefact_peer_assessment" ("assessmen...", array(size 3)) at /home/kristina/code/mahara/htdocs/lib/dml.php:1102
    insert_record("artefact_peer_assessment", object(stdClass)) at /home/kristina/code/mahara/htdocs/artefact/peerassessment/lib.php:263
    ArtefactTypePeerassessment->commit() at /home/kristina/code/mahara/htdocs/artefact/peerassessment/import/leap/lib.php:180
    LeapImportPeerassessment::import_using_strategy(object(SimpleXMLElement), object(PluginImportLeap), 1, array(size 0)) at /home/kristina/code/mahara/htdocs/lib/mahara.php:1817
    call_static_method("LeapImportPeerassessment", "import_using_strategy", object(SimpleXMLElement), object(PluginImportLeap), 1, array(size 0)) at /home/kristina/code/mahara/htdocs/import/leap/lib.php:665
    PluginImportLeap->import_from_load_mapping() at /home/kristina/code/mahara/htdocs/import/leap/lib.php:188
    PluginImportLeap->process() at /home/kristina/code/mahara/htdocs/admin/users/add.php:348
    adduser_submit(object(Pieform), array(size 25)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:544
    Pieform->__construct(array(size 8)) a...

[Robert Lyon (robertl-9)]

For the peer assessment import we also have this bug https://bugs.launchpad.net/mahara/+bug/1803101

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9719

[Steven (stevens-q)]

Commit hash: bf7a19b4ba9258f7f0d8e08e49c7c06c08995ded
Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Mahara users exists (no roles) User1 & User2
2) Mahara User1 has portfolio page that has Page instructions and a text block

TEST STEPS: HTML export
------------------------
1) Log in as Mahara User1
2) Export the page mentioned above as HTML export
3) save file to your local drive
4) open the index page in a browser
5) Verify that the page displays the page instructions ✔ BUG - No title for the block is displayed ✘

TEST STEPS: Leap2a export
------------------------
1) Log in as Mahara user
2) Export the page mentioned above as Leap2a export
3) save file to your local drive
4) Log out and log in as Mahara User2
5) Import the Leap2a file and add the new Page mentioned above
6) View the newly created page
7) Verify that the page displays the page instructions ✔

Catalyst QA Failed Testing ✘

BUG - Page Instructions not apparent as Instructions when viewing as exported HTML page

Summary - When viewing a page that has instructions in display mode, the instructions are initally hidden - User must click the instructions link to reveal the instructions. User know there must be instructions. When viewing the HTML page, the instructions directly follow the page descriptions and ther is no indication that the Instruction text is actually instructions.

Recommend: adding a subheading or background colour to the page instruction text to indicate to the user that the following text is actually instruction text.

[Steven (stevens-q)]

Bug Fixed - Page instructions now display a heading and have a grey background colour

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9719
Committed: https://git.mahara.org/mahara/mahara/commit/a86fb46ad5fca4054d447eacf44fb0872c08f1eb
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit a86fb46ad5fca4054d447eacf44fb0872c08f1eb
Author: Robert Lyon <email address hidden>
Date: Mon Apr 8 08:35:11 2019 +1200

Bug 1800421: Allow peer instructions for HTML export

Also allow embedded image export for Leap2A

This is for fixing points 2 and 3 on comment #3

behatnotneeded

Change-Id: I0f793c307b7cab978045881045722fd2150ded48
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9796

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9796
Committed: https://git.mahara.org/mahara/mahara/commit/dfd374da9edf41948982630894adb8215e24b253
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit dfd374da9edf41948982630894adb8215e24b253
Author: Robert Lyon <email address hidden>
Date: Mon Apr 8 08:35:11 2019 +1200

Bug 1800421: Allow peer instructions for HTML export

Also allow embedded image export for Leap2A

This is for fixing points 2 and 3 on comment #3

behatnotneeded

Change-Id: I0f793c307b7cab978045881045722fd2150ded48
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a86fb46ad5fca4054d447eacf44fb0872c08f1eb)

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9797

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9797
Committed: https://git.mahara.org/mahara/mahara/commit/ac0aee9ca5c318ba8ec65d8c63cb55e86718bbdf
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit ac0aee9ca5c318ba8ec65d8c63cb55e86718bbdf
Author: Robert Lyon <email address hidden>
Date: Mon Apr 8 08:35:11 2019 +1200

Bug 1800421: Allow peer instructions for HTML export

Also allow embedded image export for Leap2A

This is for fixing points 2 and 3 on comment #3

behatnotneeded

Change-Id: I0f793c307b7cab978045881045722fd2150ded48
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a86fb46ad5fca4054d447eacf44fb0872c08f1eb)
(cherry picked from commit dfd374da9edf41948982630894adb8215e24b253)

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9864

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9864
Committed: https://git.mahara.org/mahara/mahara/commit/2cd7a871f8ef7a837af91e951d3714434d1aceb1
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 2cd7a871f8ef7a837af91e951d3714434d1aceb1
Author: Robert Lyon <email address hidden>
Date: Fri Apr 26 09:16:09 2019 +1200

Bug 1800421: Needing to use older SASS variables in backport

otherwise 'make css' fails

behatnotneeded

Change-Id: I47e6fda1999e95adc561c6bdeeda5fe8246c765e
Signed-off-by: Robert Lyon <email address hidden>