Advanced Search Default Pane workstation setting not working

[Angela Kilsdonk]

Tested on 3.2.0

Setting the Advanced Search Default Pane to 'Numeric' or 'MARC Expert' in Admin>Workstation Admin does not appear to work. The Advanced Search interface continues to default to the regular advanced search tab.

Based on my testing the Default Search Library and Preferred Library settings appear to be working as expected in 3.2.

There was a similar bug a while back (https://bugs.launchpad.net/evergreen/+bug/1437112), but this appears to be a new bug. All workstation search preferences worked as expected in 3.1.

[Anna Goben (agoben)]

Confirming I see this on our 3.2 test server too.

[Cesar V (cesardv)]

Nice find Angela!

Patch for this issue is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1799963-fix-staff-cat-default-search-pane

[Angela Kilsdonk (akilsdonk)]

Confirming that Cesar's patch worked for me on master. Thanks, Cesar!

[Angela Kilsdonk (akilsdonk)]

And to make it official-- I have tested this code and consent to signing off on it with my name, Angela Kilsdonk, and my email address, <email address hidden>.

[Jason Boyer (jboyer)]

That branch breaks any opac page that isn't eventually reached via the advanced search page. (i.e. loading a record by id, etc.) This branch adds a second commit that makes everything that's not advanced search related work the same as it does today:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1799963-staff-default-adv-search / working/user/jboyer/lp1799963-staff-default-adv-search

[Jane Sandberg (sandbergja)]

Thanks for your work, Cesar, Angela, and Jason. I can confirm that Cesar's code with Jason's fix works for me.

I created a signoff branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1799963-staff-default-adv-search-signedoff

The name of the branch is user/sandbergja/lp1799963-staff-default-adv-search-signedoff

[Galen Charlton (gmc)]

Pushed to master and rel_3_2. Thanks, Cesar, Angela, Jason, and Jane!