not possible to set workstation preferences in web staff client

Bug #1437112 reported by Sally Fortin
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

It is currently not possible to set workstation search preferences in the web staff client. There are three settings available in the XUL staff client. One sets the default search library, one sets the preferred library (the library whose items float to the top), and the last sets the advanced search default pane. These need to be added to the web staff client.

Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: nobody → Victoria Lewis (vlewis-q)
Revision history for this message
Victoria Lewis (vlewis-q) wrote :

I can add my preferred library to the eg/opac/advanced url. I need to add it to the eg/opac/results url as well. Does anyone know in which function I can do that?
Thanks.
Victoria Lewis

Revision history for this message
Bill Erickson (berick) wrote :

The challenge here is that the XUL client sets the pref lib via HTTP header, which allows the client to propagate the value to all pages. We can't pass headers to iframes, though, so we'll have to propagate it some other way. We could store the values as cookies instead. The TPAC could read the 'plib' parameter from the URL (passed into the iframe), set a cookie with the value, then read the cookie on subsequent page loads, just after checking the plib CGI parameter. Then if it changes in the client, a new 'plib' value will be passed, and the server will update the cookie.

Revision history for this message
Victoria Lewis (vlewis-q) wrote :

Added code to set the default search library, the preferred library and the advanced search default pane.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/vlewis/lp1437112-not_possible_to_set_workstation_preferences

Changed in evergreen:
assignee: Victoria Lewis (vlewis-q) → nobody
tags: added: pullrequest
Kathy Lussier (klussier)
tags: added: webstaffprodcirc
Changed in evergreen:
milestone: none → 2.next
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I think the branch should be rebased on master. I get a conflict in Open-ILS/web/js/ui/default/staff/circ/in_house_use/app.js with commit 7d05cee8bceedc827c20470f98a00744115171f9

Changed in evergreen:
assignee: nobody → Christine Burns (christine-burns)
Revision history for this message
Christine Burns (christine-burns) wrote :

I have tested this code and consent to signing off on it with my name, [Christine Burns] and email address, [<email address hidden>]

Admin --> Workstation --> Set Search Preferences allows you to set default search library, the preferred library and the advanced search default pane.

tested setting values for each preference -> all work as expected

tags: added: signedoff
Revision history for this message
Christine Burns (christine-burns) wrote :

tested on Sandbox provided courtesy of MOBIUS

Changed in evergreen:
assignee: Christine Burns (christine-burns) → nobody
Revision history for this message
Blake GH (bmagic) wrote :

Just like Jason said in #4, this needs to be rebased.

In order to load it I went ahead and fixed the merge conflicts

Open-ILS/src/templates/opac/parts/searchbar.tt2
Open-ILS/src/templates/opac/results.tt2
Open-ILS/web/js/ui/default/staff/circ/in_house_use/app.js

Although there are sign-offs, I would like to express concerns about the default look of
/eg/staff/cat/catalog/index

With this patch, it shows the page template without the data. AKA

Title:
{{mvr.title()}}
Author:
{{mvr.author()}}
Pub Date:
{{mvr.pubdate()}}
Database ID:
{{record.id()}}

Revision history for this message
Kathy Lussier (klussier) wrote :

Revisiting the IRC discussion on 3/7, I'm going to remove the pullrequest and signedoff tags on this bug and I add needsrepatch tag. The code needs to be reworked to display the search screen properly when a workstation search setting is not set.

 http://irc.evergreen-ils.org/evergreen/2016-03-07#i_234484

tags: removed: pullrequest signedoff
tags: added: needsrepatch
Revision history for this message
Kathy Lussier (klussier) wrote :

Merged to master as part of today's sprint4 merge.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
milestone: 2.next → 2.12-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.