Pcbnew: DRC ignores missing connection

[Fabián Inostroza]

DRC ignores a missing connection and also the ratsnest is not shown.

See pin 5 of IC1 in the attached file.

Application: pcbnew
Version: (6.0.0-rc1-dev-982-g8a251163d), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 GnuTLS/3.5.19 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.32.0 librtmp/2.3
Platform: Linux 4.18.0-2-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

[jean-pierre charras (jp-charras)]

@Seth,

Could you have a look into this issue. It was created by commit 38c5b025c8.
I am thinking the first net in list is skipped (not tested).

The attached patch fixes this issue for me, but I need your opinion.

[Seth Hillbrand (sethh)]

Hi JP-

Yes, your patch corrects the issue. Moving the conditional, I should have moved the unconnected skip as well. Thanks for catching my mistake.

[Jeff Young (jeyjey)]

Is this also https://bugs.launchpad.net/kicad/+bug/1787961?

[KiCad Janitor (kicad-janitor)]

Fixed in revision 0f247264f80bfe8b5090e33fd3aab9a567266a78
https://git.launchpad.net/kicad/patch/?id=0f247264f80bfe8b5090e33fd3aab9a567266a78

[Seth Hillbrand (sethh)]

@Jeff- I don't think so as that report predates the change. I need to double check that that report still occurs

[Gabriel Staples (ercaguy)]

This is a duplicate: https://bugs.launchpad.net/kicad/+bug/1804691.