Custom grid columns fail to display on initial load

[Bill Erickson]

Evergreen 3.2

This is a follow-up to bug #1760997.

There is a race condition in the AngJS grid where the data retrieval code may run before the grid settings are applied. The grid settings define which columns are visible and, for certain grids, that defines what values are fetched for each row. If the data is fetched before columns are set, an incomplete data set may be retrieved. The race condition has always existed, but it's noticeable now with server-stored settings.

The fix for bug #1760997, marking some fields required, is effective, but limited to the selected columns. (It also means fetching more data then needed in many cases). Branch en route for a more holistic fix.

[Bill Erickson (berick)]

This issue is also easy to see in the /eg/staff/circ/transits/list UI. Adding (e.g.) 'Author (normalized)' as a new column and reloading the page will result in an empty value for the new author column.

Fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1798170-angjs-grid-settings-load-race

[John Amundson (jamundson)]

Another potential example: bug #1776687.

[Jason Boyer (jboyer)]

You just fixed this, I know it's crazy, here's my signoff, commit it maybe?

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1798170-angjs-grid-settings-load-race-signoff
working/user/jboyer/lp1798170-angjs-grid-settings-load-race-signoff

Less pop-py response: loading that allowed custom columns to appear on initial load even if the column wasn't displayed by default in the template. Woo.

[Galen Charlton (gmc)]

Pushed to master and rel_3_2. Thanks, Bill and Jason!