[SRU] clojure autopkgtest fails to run with openjdk-11

[Tiago Stürmer Daitx]

[Impact]
clojure1.8 fails to run.

clojure1.8 autopkgtest fails with openjdk-11 with the following message:

autopkgtest [06:21:34]: test run-clojure: - - - - - - - - - - stderr - - - - - - - - - -
Exception in thread "main" java.lang.ExceptionInInitializerError
 at clojure.main.<clinit>(main.java:20)
Caused by: java.lang.IllegalArgumentException: Must hint overloaded method: toArray, compiling:(clojure/gvec.clj:131:1)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:6875)
 at clojure.lang.Compiler.analyze(Compiler.java:6669)
 at clojure.lang.Compiler.analyze(Compiler.java:6625)
 at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:6003)
 at clojure.lang.Compiler$LetExpr$Parser.parse(Compiler.java:6319)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:6868)
 at clojure.lang.Compiler.analyze(Compiler.java:6669)
 at clojure.lang.Compiler.analyze(Compiler.java:6625)
 at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:6005)
 at clojure.lang.Compiler$FnMethod.parse(Compiler.java:5380)
 at clojure.lang.Compiler$FnExpr.parse(Compiler.java:3972)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:6866)
 at clojure.lang.Compiler.analyze(Compiler.java:6669)
 at clojure.lang.Compiler.eval(Compiler.java:6924)
 at clojure.lang.Compiler.load(Compiler.java:7379)
 at clojure.lang.RT.loadResourceScript(RT.java:372)
 at clojure.lang.RT.loadResourceScript(RT.java:363)
 at clojure.lang.RT.load(RT.java:453)
 at clojure.lang.RT.load(RT.java:419)
 at clojure.core$load$fn__1621.invoke(core.clj:5893)
 at clojure.core$load.invokeStatic(core.clj:5892)
 at clojure.core$load.doInvoke(core.clj:5876)
 at clojure.lang.RestFn.invoke(RestFn.java:408)
 at clojure.core$eval3106.invokeStatic(core.clj:6523)
 at clojure.core$eval3106.invoke(core.clj:6523)
 at clojure.lang.Compiler.eval(Compiler.java:6927)
 at clojure.lang.Compiler.load(Compiler.java:7379)
 at clojure.lang.RT.loadResourceScript(RT.java:372)
 at clojure.lang.RT.loadResourceScript(RT.java:363)
 at clojure.lang.RT.load(RT.java:453)
 at clojure.lang.RT.load(RT.java:419)
 at clojure.lang.RT.doInit(RT.java:461)
 at clojure.lang.RT.<clinit>(RT.java:331)
 ... 1 more
Caused by: java.lang.IllegalArgumentException: Must hint overloaded method: toArray
 at clojure.lang.Compiler$NewInstanceMethod.parse(Compiler.java:8206)
 at clojure.lang.Compiler$NewInstanceExpr.build(Compiler.java:7798)
 at clojure.lang.Compiler$NewInstanceExpr$DeftypeParser.parse(Compiler.java:7678)
 at clojure.lang.Compiler.analyzeSeq(Compiler.java:6868)
 ... 33 more

This is related to https://dev.clojure.org/jira/browse/CLJ-2374 and the proposed fix upstream is available at https://github.com/tirkarthi/clojure/commit/63dab8e6cb702a6b0c5b279721bee7eff0aba44f.patch

[Test Case]
Run clojure1.8's autopkgtest, the package with the fix will run ok.

[Regression Potential]
No regression is expected, the method overload declaration is expected to work under both openjdk-11 and openjdk-8.

[Tiago Stürmer Daitx (tdaitx)]

debdiff with a upstream fix [1] for clojure1.8

[1] https://github.com/clojure/clojure/commit/68d8b83138437c18f1d5cf9ba46c056aa2701d23

[Launchpad Janitor (janitor)]

This bug was fixed in the package clojure1.8 - 1.8.0-7ubuntu1

---------------
clojure1.8 (1.8.0-7ubuntu1) cosmic; urgency=medium

  * debian/patches/03-add-toarray-hint-type-68d8b83138437c18.patch:
    Add hint type to toArray method to resolve ambiguity introduced by
    JDK 11. (LP: #1796985).

 -- Tiago Stürmer Daitx <email address hidden> Wed, 10 Oct 2018 16:47:36 +0000

[Łukasz Zemczak (sil2100)]

Hello Tiago, or anyone else affected,

Accepted clojure1.8 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/clojure1.8/1.8.0-7ubuntu1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Tiago Stürmer Daitx (tdaitx)]

I verified that clojure1.8 version 1.8.0-7ubuntu1~18.04.1 autopkgtests works as expected.

[Launchpad Janitor (janitor)]

This bug was fixed in the package clojure1.8 - 1.8.0-7ubuntu1~18.04.1

---------------
clojure1.8 (1.8.0-7ubuntu1~18.04.1) bionic; urgency=medium

  * Backport from Cosmic. (LP: #1814133)

clojure1.8 (1.8.0-7ubuntu1) cosmic; urgency=medium

  * debian/patches/03-add-toarray-hint-type-68d8b83138437c18.patch:
    Add hint type to toArray method to resolve ambiguity introduced by
    JDK 11. (LP: #1796985).

clojure1.8 (1.8.0-7) unstable; urgency=medium

  * Update Vcs-* links to point to the clojure-team repo.
  * Update preinst script to match 1.9.0-5's.
  * Update Standards to assert compliance with 4.2.0.
  * Ensure tests run against clojure1.8, no matter what's installed.

clojure1.8 (1.8.0-6) unstable; urgency=medium

  * Fix clojure.jar conflict in /usr/share/java that's causing upgrade
    issues.
  * Update the versions we break to reflect that alternatives is
    properly managing /usr/share/java/clojure.jar now.
  * Update Vcs links and Standards-Version.

 -- Tiago Stürmer Daitx <email address hidden> Wed, 06 Feb 2019 16:34:21 +0000