Add "Loading" indicator to Open Badges block

Bug #1796590 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

It takes a bit (several seconds) to fetch Open Badges via the API calls. Until they are displayed, the block is empty and it doesn't look like anything is happening. It would be good to have a "Loading" indicator until the first badges start loading to ensure people looking at it that nothin is broken.

To replicate:

1. Place an Open Badges block onto your page.
2. Select a number of badges from your account.
3. View the page in "Display" mode.
Expected result: "Loading" icon indicates that badges are being fetched.
Actual result: Block sits empty until badges load.

Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9212

Revision history for this message
Steven (stevens-q) wrote :

Bug Fixed - a spinner and the word loading are displayed while the portfolio page is loading to badges block on the page

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9212
Committed: https://git.mahara.org/mahara/mahara/commit/70e60fe7decb5c6db1db4c64b2d3ec13ae061936
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 70e60fe7decb5c6db1db4c64b2d3ec13ae061936
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Oct 10 15:32:36 2018 +1300

Bug 1796590: Add "Loading" icon to blocks load by ajax

behatnotneeded

Change-Id: I188956c7b874e8ee901381ab7a554e6d58ac33ac

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9233

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9233
Committed: https://git.mahara.org/mahara/mahara/commit/e4d46877fa32c0bcac4451e4c0901bfeed2c9a48
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit e4d46877fa32c0bcac4451e4c0901bfeed2c9a48
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Oct 10 15:32:36 2018 +1300

Bug 1796590: Add "Loading" icon to blocks load by ajax

behatnotneeded

Change-Id: I188956c7b874e8ee901381ab7a554e6d58ac33ac
(cherry picked from commit 70e60fe7decb5c6db1db4c64b2d3ec13ae061936)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 19.04.0 → 18.10.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.