error when creating a site skins

[Cecilia Vela Gurovic]

Having Skins enabled in the site

- Log in as site admin
- Go to Admin menu->Configure site->Skins
- Click on 'Create skin'
- Open the browser console
- Set title to 'Skin title' and save

Expected result: The site skin is saved and we are redirtected to the list of site skins
Actual result: The form gets stuck in loading and we see the following error message in the browsers console:

 [Show/hide message details.] ReferenceError: designskinform_body_background_image is not defined[Learn More] design.php:50:7
designskinform_callback
http://mahara/skin/design.php:50:7
Pieform/this.processForm/window.pieformHandlers[self.data.name]
http://mahara/lib/pieforms/static/core/pieforms.js:239:25
sendResult
http://mahara/skin/design.php:4:13
onload
http://mahara/skin/design.php:1:1

I think this could be related to not allowing to set a background image for a site skin and the changes made for https://bugs.launchpad.net/mahara/+bug/1782729

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9202

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9202
Committed: https://git.mahara.org/mahara/mahara/commit/5444b4ab4da13eb2f7df47524fddd1dcb4ec3048
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 5444b4ab4da13eb2f7df47524fddd1dcb4ec3048
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Oct 8 09:41:01 2018 +1300

Bug 1795758: site skin update not submitted by js

personal skins are submitted by js because
a background image can be added.
We dont allow this for a site skin,
so the submission method has to be changed.

behatnotneeded

Change-Id: I28f83d4bbc6318ec9ff1cc9dc899833d6ba0dcfb

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9206

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9206
Committed: https://git.mahara.org/mahara/mahara/commit/d583d13699e7223d22103ea90bc8885404d313d2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit d583d13699e7223d22103ea90bc8885404d313d2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Oct 8 09:41:01 2018 +1300

Bug 1795758: site skin update not submitted by js

personal skins are submitted by js because
a background image can be added.
We dont allow this for a site skin,
so the submission method has to be changed.

behatnotneeded

Change-Id: I28f83d4bbc6318ec9ff1cc9dc899833d6ba0dcfb
(cherry picked from commit 5444b4ab4da13eb2f7df47524fddd1dcb4ec3048)