Turn delete button into button and add confirmation dialogue when deleting IdP
Bug #1795096 reported by
Kristina Hoeppner
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
High
|
Cecilia Vela Gurovic | ||
Bug Description
In bug #1716820 we introduced that the metadata of an IdP can be deleted when not used anymore. That's been added to /admin/
The confirmation dialogue is missing and the deletion is immediate. Since we only have a "Save" button but no "Cancel", it can't be undone. Since it is a distructive method, a confirmation pop-up would be useful as we have for other delete actions.
The icon should also sit on a button. It doesn't need a heading as we normally do not have headings for icons. If the heading is kept, the button needs to move into the middle of the column to sit correctly under the heading.
Revision history for this message
| Kristina Hoeppner (kris-hoeppner) wrote | #1 |
| Changed in mahara: | |
| milestone: | 18.10.0 → 18.10rc1 |
| Changed in mahara: | |
| assignee: | nobody → Cecilia Vela Gurovic (ceciliavg) |
| status: | Confirmed → In Progress |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #2 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #3 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #5 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote | #4 |
| Changed in mahara: | |
| milestone: | 18.10rc1 → 18.10.0 |
| status: | In Progress → Fix Committed |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/