[SRU] Autopkgtests fail with flatpak 1.0.X, due to missing -y in test scripts

[Andrew Hayzen]

New versions of flatpak have extra prompts in the CLI when performing certain actions. Flatpak-builder has some tests which call directly to the flatpak CLI, with new flatpak versions these tests fail - as shown here [0].

Upstream these tests have been fixed with these commits [1] [2] which simply adds "-y" to the relevant parts of the test scripts.

[Impact]

This bug does not affect users, it is about fixing autopkgtest failures of flatpak-builder 0.10.9-1 being run against flatpak 1.0.1-0ubuntu0.1 (for the SRU bug 1787917).

Without this fix autopkgtests will fail, blocking the flatpak update.

[Test Case]

The test case is that before the autopkgtests would fail against flatpak 1.0.1-0ubuntu0.1, as seen here [0], but with this change these autopkgtests should pass.

[Regression Potential]

Regression potential is low, as this change is simply adjusting the test scripts using upstream changes.

I have tested that "$ gnome-desktop-testing-running flatpak-builder", fails before and passes after this change.

[Other Info]

This should be submitted with bug 1787917 and is to fix the autopkgtest tests that change.

0 - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/f/flatpak-builder/20180927_115654_e352b@/log.gz
1 - https://salsa.debian.org/debian/flatpak-builder/commit/582c1b5708735a057a33be78e447f891faff3369
2 - https://salsa.debian.org/debian/flatpak-builder/commit/6d9f874c12ea3e742f15fe014138884da9130e08

[Andrew Hayzen (ahayzen)]

Please reject the existing upload, while testing and going through upstream commits I noticed that I had missed another instance of -y fixes (https://github.com/flatpak/flatpak-builder/commit/247525a8002557d99878373aea931f969a59030e). This will be re-submitted in a subsequent upload. (sorry for the noise).

[Andrew Hayzen (ahayzen)]

FYI the upload was rejected and a new one has been submitted, so the one in the queue is now the correct one to review.

[Andrew Hayzen (ahayzen)]

I see the latest upload was rejected, but I cannot find any reasoning anywhere (must be looking in the wrong places). Can someone point to the reason why this was rejected ?

[Łukasz Zemczak (sil2100)]

Ah, yes, the rejection message usually lands in the inbox of the person performing the upload. The reason was a missing valid bug reference in the changelog. There was a bug number, but it was not formatted correctly so it didn't make it to the .changes file. Such uploads cannot be accepted as the SRU tools wouldn't be able to track the bug verification. It's been reuploaded and now being re-reviewed.

[Łukasz Zemczak (sil2100)]

Hello Andrew, or anyone else affected,

Accepted flatpak-builder into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/flatpak-builder/0.10.9-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andrew Hayzen (ahayzen)]

@sil2100, Thanks, yeah Ken messaged me and we realised the message was only sent to the uploader. Sorry for not noticing the typo, I'll note to double check this in the future :-)

I have run the autopkgtests on a bionic VM, which passed successfully. I have done exploratory testing of the flatpak-builder CLI. And autopkgtests in CI are now passing [3] [4]. Therefore I am marking this as verification-done-bionic.

3 - http://autopkgtest.ubuntu.com/packages/f/flatpak-builder
4 - http://autopkgtest.ubuntu.com/packages/f/flatpak-builder/bionic/amd64

[Launchpad Janitor (janitor)]

This bug was fixed in the package flatpak-builder - 0.10.9-1ubuntu1

---------------
flatpak-builder (0.10.9-1ubuntu1) bionic; urgency=medium

  * Fix autopkgtest failures with flatpak 1.0 due to missing -y
    in test scripts (LP: #1794875)
    - debian/patches/0001-install-deps-Always-pass-y-when-installing.patch:
      Upstream patch to always pass -y when using --install-deps-from
    - debian/patches/0002-Fix-tests-with-new-flatpak.patch:
      Upstream patch to fix tests with new flatpak
    - debian/patches/0003-Fix-install-with-latest-flatpak-by-passing-y.patch:
      Upstream patch to always pass -y when using --install

 -- Andrew Hayzen <email address hidden> Thu, 27 Sep 2018 21:18:06 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for flatpak-builder has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.