Mahara

Clean up session duplication between auth/session and auth/saml

Bug #1794628 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Lisa Seeto
Mahara 19.10.0

Bug Description

There is a bunch of checks for session handlers done by auth/session.php and also done by auth/saml/config/config.php

We can make these checks simplified into one place

Tags: refactoring
Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 19.04.0
status: New → Confirmed
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: Undecided → Medium
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: Medium → Wishlist
milestone: 19.04.0 → 19.10.0
tags: added: refactoring
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)
Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9688

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9688
Committed: https://git.mahara.org/mahara/mahara/commit/fe195ddc4b8c095f38f1e832d99e58830c328f81
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fe195ddc4b8c095f38f1e832d99e58830c328f81
Author: Lisa Seeto <email address hidden>
Date: Tue Apr 2 09:33:34 2019 +1300

Bug 1794628: Clean up session duplication between auth/session and auth/saml

created auth_configure_session_handlers($sessiontype) in auth/lib to
house session handler checks, cleaned up code in auth/session and auth/saml/config/config.

behatnotneeded

Change-Id: Idc84da9122a50fe2a65a76420ce38c853005e69b
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10262

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10262
Committed: https://git.mahara.org/mahara/mahara/commit/a38ddad4f44fdd84fdc801ac4934bcf9700f9af6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a38ddad4f44fdd84fdc801ac4934bcf9700f9af6
Author: Robert Lyon <email address hidden>
Date: Thu Aug 15 12:54:33 2019 +1200

Bug 1794628: Allow config errors session setup to be right

behatnotneeded

Change-Id: I37aa210a7446fabc3513b00798eefb86b8e50303
Signed-off-by: Robert Lyon <email address hidden>

Rebecca Blundell (rjb-dev)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.