Mahara

make a more generic js workround for target _blank

Bug #1792246 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 18.10.0

Bug Description

In bug https://bugs.launchpad.net/mahara/+bug/1558361 we removed the use of target _blank because of XSS issues.

There is a js workaround to the problem now and so we can allow the 'target="_blank" again and then override it via jQuery.

Actually it would be safer to do something like 'data-target="_blank"' that way if a jQuery error is created on the page the link would not fall back to old behaviour

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9129

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: New → In Progress
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9129
Committed: https://git.mahara.org/mahara/mahara/commit/e129f68764414a151e013099a36ea867558c2071
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e129f68764414a151e013099a36ea867558c2071
Author: Matt Clarkson <email address hidden>
Date: Thu Sep 13 10:29:18 2018 +1200

Bug 1792246: generic open in new window JS

behatnotneeded - current tests will verify this change

Change-Id: I2e9a0e945aacfbc7f45ee219d90076553ca530a4

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
tags: added: nominatedfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.