/usr/share/apport/apport-gtk:KeyError:/usr/share/apport/apport-gtk@598:run_argv:run_crashes:run_crash

Bug #1791324 reported by errors.ubuntu.com bug bridge
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Medium
Didier Roche-Tolomelli
Bionic
Fix Released
Medium
Didier Roche-Tolomelli

Bug Description

[Impact]
 * The Ubuntu Error Tracker has been receiving reports about a problem regarding apport. This problem was most recently seen with package version 2.20.10-0ubuntu5, the problem page at https://errors.ubuntu.com/problem/64f362ed27e5f6069d78b02c2cbca5c09fcc19ee
 * The theory is that those crashes are trigger by reports generated (but not send) pre apport 2.20.9-0ubuntu7.3. They don't hafe thus the "remember" key, and thus, the new apport, when reporting, is crashing.
 * We now ignore if the key isn't present and just consider the answer as "false", which is a no-op.

[Test Case]
 * Install apport 2.20.9-0ubuntu7.1
 * Generate a crash but don't report it.
 * Upgrade to apport apport 2.20.9-0ubuntu7.3
 * Report this crash.
   -> No apport crash should be triggered

[Regression Potential]
 * We are doing a python2 compatible try/except to ignore the KeyError which was the regression. It doesn't seem it can trigger other regressions.

-------

The Ubuntu Error Tracker has been receiving reports about a problem regarding apport. This problem was most recently seen with package version 2.20.10-0ubuntu5, the problem page at https://errors.ubuntu.com/problem/64f362ed27e5f6069d78b02c2cbca5c09fcc19ee contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

Related branches

Revision history for this message
Brian Murray (brian-murray) wrote :

Here's the Traceback:

Traceback (most recent call last):
  File "/usr/share/apport/apport-gtk", line 598, in <module>
  File "/usr/lib/python3/dist-packages/apport/ui.py", line 709, in run_argv
    return self.run_crashes()
  File "/usr/lib/python3/dist-packages/apport/ui.py", line 265, in run_crashes
    self.run_crash(f)
  File "/usr/lib/python3/dist-packages/apport/ui.py", line 322, in run_crash
    if response['remember']:
KeyError: 'remember'

This was introduced in revision 3204 of apport which has been SRU'ed to Ubuntu 18.04.

tags: added: regression-update
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

(Set it to medium as the thoery is that it's only happening with older, staggering, crashes)

description: updated
description: updated
Changed in apport (Ubuntu):
assignee: nobody → Didier Roche (didrocks)
Changed in apport (Ubuntu Bionic):
assignee: nobody → Didier Roche (didrocks)
Changed in apport (Ubuntu):
importance: Undecided → High
importance: High → Medium
Changed in apport (Ubuntu Bionic):
importance: Undecided → Medium
Revision history for this message
Brian Murray (brian-murray) wrote :

I received this crash today and I believe it happened because I had closed a previous apport crash dialog by using the "x" in the upper right hand corner.

Revision history for this message
Brian Murray (brian-murray) wrote :

Ah actually, I think my apport versions were mismatched. As we can see below python3-apport was updated but apport-gtk and apport were not.

105 Start-Date: 2018-09-13 11:00:45
106 Commandline: apt install apport-retrace
107 Requested-By: bdmurray (1000)
108 Install: apport-retrace:amd64 (2.20.9-0ubuntu7.3)
109 Upgrade: python3-apport:amd64 (2.20.9-0ubuntu7.2, 2.20.9-0ubuntu7.3)
110 End-Date: 2018-09-13 11:00:47
111
112 Start-Date: 2018-09-13 15:25:13
113 Commandline: apt-get install apport-gtk
114 Requested-By: bdmurray (1000)
115 Upgrade: apport-gtk:amd64 (2.20.9-0ubuntu7.2, 2.20.9-0ubuntu7.3)
116 End-Date: 2018-09-13 15:25:13
117
118 Start-Date: 2018-09-13 15:26:03
119 Commandline: apt-get install apport
120 Requested-By: bdmurray (1000)
121 Upgrade: apport:amd64 (2.20.9-0ubuntu7.2, 2.20.9-0ubuntu7.3)
122 End-Date: 2018-09-13 15:26:08

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Ok, so the current fix in UNAPPROVED will prevent that at least ;)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.10-0ubuntu11

---------------
apport (2.20.10-0ubuntu11) cosmic; urgency=medium

  * Drop build/test dependency on obsolete libnih-dev.

 -- Steve Langasek <email address hidden> Wed, 12 Sep 2018 20:28:31 -0700

Changed in apport (Ubuntu):
status: New → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello errors.ubuntu.com, or anyone else affected,

Accepted apport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.9-0ubuntu7.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in apport (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I've generated a report with a version pre 7.3, then, upgrade apport and report it with 7.4 and I didn't trigger any crash.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for apport has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.9-0ubuntu7.4

---------------
apport (2.20.9-0ubuntu7.4) bionic; urgency=medium

  * Handle old reports generated pre-apport with "remember" option.
    If the option isn't there, consider as false. (LP: #1791324)

 -- Didier Roche <email address hidden> Mon, 10 Sep 2018 18:20:14 +0200

Changed in apport (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.