Update to 0.6.50

[Sebastien Bacher]

The upstream changes are non trivial and there is work to update the patches but that would be useful to do

[Robert Ancell (robert-ancell)]

I have all the patches updated except for 0010-set-language.patch

[Robert Ancell (robert-ancell)]

Gunnar - could you perhaps have a look at 0010-set-language.patch? In particular I'm not sure how we want to do the fallback language property handling in src/user.c - the new code uses autogenerated property handling so we can't intercept it as easily. I guess we could just set the fallback values on initialization?

[Gunnar Hjalmarsson (gunnarhj)]

Hi Robert,

I see that the user_set_property() function has been dropped. Without having looked closely at the code, setting them on initialization sounds reasonable, if that can be done without confusing accountsservice. The goal is that querying the "Language" or "FormatsLocale" property should return the proper current value even if nothing has (yet) been saved in /var/lib/AccountsService/users/<username>.

Initialization - would that be the user_update_from_keyfile() function?

Right now I don't have access to a working cosmic install. Possibly it's some hardware incompatibility issue, but whatever the reason is, I'm not able to do any work in a sensible way at the moment. So I'm hoping you can fix also 0010-set-language.patch ..

Once I have fixed my cosmic, I'll be happy to test to make sure that it works as expected.

Btw, is your work in progress available in a repository somewhere?

[Gunnar Hjalmarsson (gunnarhj)]

One more thought: If we would add the fallback values on initialization, can it be done without updating the keyfile? If not there is a complication, since we need to keep the keyfile and ~/.pam_environment in sync.

[Robert Ancell (robert-ancell)]

I don't have it currently in a branch but I'm working on doing that.

[Robert Ancell (robert-ancell)]

Patches are here:
https://gitlab.freedesktop.org/rancell/accountsservice/tree/ubuntu

Please test / look over.

[Robert Ancell (robert-ancell)]

I'm also looking at dropping the XHasMessages, BackgroundFile and KeyboardLayouts patches, as these are all obsolete with LightDM 1.26 - Is there anywhere else that might be using them?

Does anyone know if the InputSources and FormatsLocale is still applicable and which components use it? If they are still used I'd like to fix those to use the AccountsService extension mechanism - then we can drop the patches.

[Sebastien Bacher (seb128)]

Hey Robert,

Le 06/09/2018 à 10:27, Robert Ancell a écrit :
> I'm also looking at dropping the XHasMessages, BackgroundFile and
> KeyboardLayouts patches, as these are all obsolete with LightDM 1.26 -
> Is there anywhere else that might be using them?

How "obsolete"? XHasMessages is (was?) using by unity-greeter to
indicate with an icon that there are pending messages in the session.
Did that feature got removed or superseeded?

[Robert Ancell (robert-ancell)]

On Thu, Sep 6, 2018 at 9:42 PM Sebastien Bacher <email address hidden> wrote:

> Hey Robert,
>
> Le 06/09/2018 à 10:27, Robert Ancell a écrit :
> > I'm also looking at dropping the XHasMessages, BackgroundFile and
> > KeyboardLayouts patches, as these are all obsolete with LightDM 1.26 -
> > Is there anywhere else that might be using them?
>
> How "obsolete"? XHasMessages is (was?) using by unity-greeter to
> indicate with an icon that there are pending messages in the session.
> Did that feature got removed or superseeded?
>
> LightDM 1.26 uses the AccountsService extention mechanism to store this
data, so the patch is obsolete.

[Sebastien Bacher (seb128)]

Le 06/09/2018 à 21:25, Robert Ancell a écrit :
> LightDM 1.26 uses the AccountsService extention mechanism to store
> this data, so the patch is obsolete.
It looks like indicator-messages still use XHasMessages, in which case
that would need to be ported to the new api?

https://bazaar.launchpad.net/~indicator-applet-developers/indicator-messages/trunk.16.10/view/head:/src/im-accounts-service.c#L189

It looks like BackgroudFile is fine since you ported
unity-settings-daemon to the new API

Unsure where KeyboardLayouts is being used, indicator-keyboard and
unity-settings-daemon don't seem to reference to it

[Gunnar Hjalmarsson (gunnarhj)]

Thought I'd show a sign of life.

@Robert: Since you asked about the FormatsLocale patch, I'd like to mention that it's necessary for 0010-set-language.patch. Actually we tried to upstream it years ago:

https://gitlab.freedesktop.org/accountsservice/accountsservice/issues/22

Unfortunately I have still not access to a working updated Cosmic install. The 2018-08-22 ISO works on my machine, but when I upgrade, most network connections are lost at next reboot. I can run commands like ping() and host(), but not apt(), and Firefox does not find anything. Just tried with the 2018-09-08 ISO, but it didn't help. Will seek support tomorrow. (Any hints about possible causes would be appreciated, of course.)

[Robert Ancell (robert-ancell)]

indicator-messages was updated in https://code.launchpad.net/~robert-ancell/indicator-messages/has-messages/+merge/355127

[Gunnar Hjalmarsson (gunnarhj)]

I have tested "my" parts of the pending upgrade (SetLanguage and SetFormatsLocale) and found that the move of the user_get_fallback_value() call to user_new() triggered a need to tweak user_change_language_authorized_cb() and user_change_formats_locale_authorized_cb() to prevent confusion. I'll get back with a proposal.

I put it in a PPA for convenience for the case someone wants to test other aspects of the new version.

https://launchpad.net/~gunnarhj/+archive/ubuntu/accountsservice

[Sebastien Bacher (seb128)]

That's for next cycle, tagging to reflect that

[Sebastien Bacher (seb128)]

The disco cycle is starting so that's unblocked now

[Launchpad Janitor (janitor)]

This bug was fixed in the package accountsservice - 0.6.50-0ubuntu1

---------------
accountsservice (0.6.50-0ubuntu1) disco; urgency=medium

  * New upstream release (LP: #1789502)
  * debian/control:
    - Bump minimum version of libglib2.0-dev
  * debian/rules:
  * debian/patches/0005-gdm_config_file_path.patch:
    - Set config file using configure args
  * debian/libaccountsservice0.symbols:
    - Updated
  * debian/patches/0001-Move-cache-cleanup-out-into-a-common-function-and-cl.patch:
  * debian/patches/0002-On-startup-clean-out-the-data-of-removed-users.patch:
  * debian/patches/1002-dont-override-standardoutput.patch:
    - Applied upstream
  * debian/patches/0015-debian-nologin-path.patch:
    - No longer needed
  * debian/patches/0008-nopasswdlogin-group.patch:
  * debian/patches/2001-filtering_out_users.patch:
    - Remove unused patches

 -- Robert Ancell <email address hidden> Mon, 12 Nov 2018 10:52:43 +1300