Error message when sharing a page

[Cecilia Vela Gurovic]

When creating a view and sharing it, if we select an end date older that today it will display an error message for this. That is expected and correct.

But there is a second error message:

[WAR] 6c (lib/form/elements/viewacl.php:67) Undefined index: id
Call stack (most recent first):

    log_message("Undefined index: id", 8, true, true, "/home/ceciliavg/maharacode/mahara/htdocs/lib/form/...", 67) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:521
    error(8, "Undefined index: id", "/home/ceciliavg/maharacode/mahara/htdocs/lib/form/...", 67, array(size 18)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/form/elements/viewacl.php:67
    pieform_element_viewacl(object(Pieform), array(size 13)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:1509
    Pieform->build_element_html(array(size 13)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:725
    Pieform->build() at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:169
    Pieform::process(array(size 9)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5161
    pieform(array(size 9)) at /home/ceciliavg/maharacode/mahara/htdocs/view/accessurl.php:520

[Cecilia Vela Gurovic (ceciliavg)]

In the share view screen, when there is an error in the field values,
like an end date older that today, the form with all the rows
is displayed again. This includes the 'Share with' empty row
that actually has no values, that's why there is an exception
with "Undefined index:" message.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9055

[Kristina Hoeppner (kris-hoeppner)]

Tagged "Medium" as the majority of people would most likely not select an end date in the past.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9055
Committed: https://git.mahara.org/mahara/mahara/commit/831ca4f91b248055d63a86c491d6abea0b5ac7bd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 831ca4f91b248055d63a86c491d6abea0b5ac7bd
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Aug 8 11:27:22 2018 +1200

Bug 1785924: display viewacl form - avoid checking values for the empty row

behatnotneeded

Change-Id: I41f94c21bf05d6fbdf7ff1d57ef97a0f5b7edda8