Eeschema: cannot edit text in field edit dialog

[Wayne Stambaugh]

A very recent change broke the field edit dialog text control. I cannot modify or select the contents of the text control so it is effectively impossible to edit field text. This is true for all field types.

Application: kicad
Version: (6.0.0-rc1-dev-157-g05b2060e1), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.59.0 OpenSSL/1.0.2o (WinSSL) zlib/1.2.11 brotli/1.0.5 libidn2/2.0.5 nghttp2/1.32.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.59.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@Wayne, I assume you're talking about the individual field edit dialog (pic attached) and not the fields grid in the Edit Symbol Properties dialog?

If so I can't reproduce it. My tree is about 8 hours out-of-date, but I assume you don't mean that recently?

[Jeff Young (jeyjey)]

@Devs, is anyone else seeing this?

[Maciej Suminski (orsonmmz)]

Cannot confirm on Linux. I have tested the dialog show in #1, Symbol Properties dialog and Symbol Fields dialog.

[jean-pierre charras (jp-charras)]

I confirm this issue on Windows.

Looks like:
void DIALOG_EDIT_ONE_FIELD::OnSetFocusText( wxFocusEvent& event )

is missing a call to event.Skip() at the end of this method.

[Jeff Young (jeyjey)]

Thanks, JP. I’ll fix it up.

> On 26 Jul 2018, at 10:25, jean-pierre charras <email address hidden> wrote:
>
> I confirm this issue on Windows.
>
> Looks like:
> void DIALOG_EDIT_ONE_FIELD::OnSetFocusText( wxFocusEvent& event )
>
> is missing a call to event.Skip() at the end of this method.
>
> --
> You received this bug notification because you are a member of KiCad Bug
> Squad, which is subscribed to KiCad.
> https://bugs.launchpad.net/bugs/1783615
>
> Title:
> Eeschema: cannot edit text in field edit dialog
>
> Status in KiCad:
> Triaged
>
> Bug description:
> A very recent change broke the field edit dialog text control. I
> cannot modify or select the contents of the text control so it is
> effectively impossible to edit field text. This is true for all field
> types.
>
> Application: kicad
> Version: (6.0.0-rc1-dev-157-g05b2060e1), release build
> Libraries:
> wxWidgets 3.0.4
> libcurl/7.59.0 OpenSSL/1.0.2o (WinSSL) zlib/1.2.11 brotli/1.0.5 libidn2/2.0.5 nghttp2/1.32.0
> Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
> Build Info:
> wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
> Boost: 1.67.0
> OpenCASCADE Community Edition: 6.9.1
> Curl: 7.59.0
> Compiler: GCC 7.3.0 with C++ ABI 1011
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_ACTION_MENU=OFF
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_USE_OCC=OFF
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1783615/+subscriptions

[KiCad Janitor (kicad-janitor)]

Fixed in revision cd3d4b106ad72ba6604836f911271af38c0b0423
https://git.launchpad.net/kicad/patch/?id=cd3d4b106ad72ba6604836f911271af38c0b0423