Budgie Hotcorners applet crashes due to TypeError

[Jacob Vlijm]

Budgie Extras is a set of python based applets that are either preinstalled or are available to be individually installed. They are exclusive only to budgie desktop users and cannot be installed or run on any other desktop environment.

A number of issues have been raised since the 18.04 release. As part of ongoing 18.04 support the Ubuntu Budgie Team proposed to wrap up a series of 6 fixes and was released by version 0.4.4ubuntu1.1.

The rollout of the above version was automatically stopped due to the following error: https://errors.ubuntu.com/problem/8091d5b02b0073ebc980b61b5c271e54e5be1ea4

This SRU specifically targets this error report - and hence will unblock the original 6 SRU fixes.

[Impact]

 HiDPI users have found that accidental activation of hotcorners capability is difficult to control due to the hard-coded and fixed pixel way-point i.e. the higher resolution means the actual activation point is tiny compared to standard/low resolution laptops and desktops. It is therefore highly likely that hotcorners will be accidentally activated breaking the users workflow.

 The impact is for Ubuntu Budgie only and anyone running the budgie desktop together with the Hotcorners applet.

[Test Case]

 1. Using Budgie Settings, check that on a panel the Hotcorners applet has been added - please note, the hotcorners applet is installed through the package "budgie-hotcorners-applet"
 2. Check that the hotcorners pressure option is enabled.
 3. Slide the pressure bar to the right to make the activation of hotcorners less likely. Slide the pressure bar to the left to make the activation of hotcorners more likely.
 4. Ensure a hotcorner is set to activate an action by using the panel hotcorners applet
 5. Move the mouse cursor to the corner - it will respect the pressure level set
 6. Repeat steps 3, 4 and 5 several times with different pressure levels.

[Regression Potential]

 * The worst case scenario is that the activation point remains inconclusive for a wider and higher range of resolutions that was not expected. This is no different from the current situation and the accidental activation will continue. This can be mitigated easily by removing the panel applet via Budgie Settings or uninstalling the applet via command line/ Software Center

 * Ubuntu Team has independently verified that the fix works using a HiDPI based laptop as well as a standard resolution laptop.

[Other Info]

 A code logic check as been made to confirm the resolution of the issue reported. Additional error trapping has been added to force a valid logic check rather than the "NoneType" vs "float" as reported.

Original description

On the released fix: `0.4.4-0ubuntu1.1`, possibly the following error occurs:
`TypeError: '>=' not supported between instances of 'float' and 'NoneType'`, if the pressure-settings file exists, but has incorrect content.

[fossfreedom (fossfreedom)]

Current package v1.1 of budgie-extras has been halted from stable release due to 12 reports being received.

v1.2 to be created with a targeted hotfix to unblock the main v1.1 SRU updates.

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-extras - 0.5.0-1ubuntu2

---------------
budgie-extras (0.5.0-1ubuntu2) cosmic; urgency=medium

  * Bug-fix release
    - fix hotcorners pressure calculation causing crash of the
      applet (LP: #1781981)

 -- David Mohammed <email address hidden> Mon, 16 Jul 2018 19:55:24 +0100

[Łukasz Zemczak (sil2100)]

Hello Jacob, or anyone else affected,

Accepted budgie-extras into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-extras/0.4.4-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jacob Vlijm (vlijm)]

I tested version 0.4.4-0ubuntu1.2. It looks fine, no errors occured.

[Launchpad Janitor (janitor)]

This bug was fixed in the package budgie-extras - 0.4.4-0ubuntu1.2

---------------
budgie-extras (0.4.4-0ubuntu1.2) bionic; urgency=medium

  * Bug-fix release
    - fix hotcorners pressure calculation causing crash of the
      applet (LP: #1781981)
      Refresh of hotcorners.patch with additional commit

 -- David Mohammed <email address hidden> Mon, 16 Jul 2018 20:40:27 +0100

[Adam Conrad (adconrad)]

The verification of the Stable Release Update for budgie-extras has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.