Remove slideshow.js

Bug #1779600 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

we are using bootstrap carousel instead, according to first lines in file artefact/file/blocktype/gallery/js/slideshow.js

and couldn't find any reference to this file in the code

Changed in mahara:
status: New → In Progress
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8991

summary: - check if slideshow.js is still needed
+ Remove slideshow.js
Changed in mahara:
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8991
Committed: https://git.mahara.org/mahara/mahara/commit/dd7ca4d47e2c5e331ca8799bf6840a879375a58b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dd7ca4d47e2c5e331ca8799bf6840a879375a58b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 6 13:35:31 2018 +1200

Bug 1779600: removing slideshow.js

This js file was loaded when calling
function get_instance_javascript() in
artefact/file/blocktype/gallery/lib.php

The line that included that file was removed when adding bootstrap
There are no calls to the only function defined in slideshow.js,
I think is safe to remove the file.

behatnotneeded

Change-Id: Iddcc6419a06cfccebdd3d243680ee653fd5cae2d

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
no longer affects: mahara/17.04
no longer affects: mahara/17.10
no longer affects: mahara/18.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.