update-notifier always present apport-gtk UI on crashes, even on autoreport mode

[Didier Roche-Tolomelli]

[Impact]
Apport-gtk is currently always started, even when whoopsie is installed and set in auto or never report mode.

This is a regression since we moved from upstart to a systemd service. apport-gtk UI is always started, even in autoreport mode.
The file condition path for autoreport isn't in the systemd unit.
This is also the case when never reporting is enabled.

[Test Case]
The test cases depend on g-c-c 1:3.28.1-0ubuntu1.18.04.2
https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.28.1-0ubuntu1.18.04.2

Test case 1:
1. install new version of update-notifier and restart your session
2. in g-c-c, set apport to always report errors
3. generate a crash (coredump)
4. wait a little, ensure no apport-gtk UI is started

Test case 2:
1. in g-c-c, set apport to never report errors
2. generate a crash (coredump)
3. wait a little, ensure no apport-gtk UI is started

Test case 3:
1. in g-c-c, set apport to manually report errors
2. generate a crash (coredump)
3. wait a little, ensure apport-gtk UI is started

Test case 4:
1. in g-c-c, set apport to automatically or never report errors
2. uninstalled whoopsie package
3. generate a crash (coredump)
4. wait a little, ensure apport-gtk UI is started

[Regression potential]

The patch hasn't many branch and only impact the "show apport-gtk" part. Any regressions will be easily detected by the previous test cases.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.192.6

---------------
update-notifier (3.192.6) cosmic; urgency=medium

  * Only show apport UI if whoopsie is not in auto or never reporting mode.
    (LP: #1778697)
  * Ensure that when we move to systemd user session, we don't regress
    as well, taking into account the case where whoopsie isn't installed
    either.

 -- Didier Roche <email address hidden> Tue, 26 Jun 2018 17:04:33 +0200

[Brian Murray (brian-murray)]

Hello Didier, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jean-Baptiste Lallement (jibel)]

With version 3.192.1.2 from proposed, test case 2 is failing. Marking as verification-failed

[Łukasz Zemczak (sil2100)]

Hello Didier, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.1.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jean-Baptiste Lallement (jibel)]

I have reproduced the problem with update-notifier 3.192.1.1 in bionic-updates and have verified that the version of update-notifier 3.192.1.3 in -proposed fixes the issue.

Marking as verification-done

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-notifier - 3.192.1.3

---------------
update-notifier (3.192.1.3) bionic; urgency=medium

  * Use absolute patch when testing if whoopsie service is enabled.
    (Thanks Jean-Baptiste!)
  * Add some debug messages

update-notifier (3.192.1.2) bionic; urgency=medium

  * Only show apport UI if whoopsie is not in auto or never reporting mode.
    (LP: #1778697)

 -- Didier Roche <email address hidden> Mon, 02 Jul 2018 11:27:13 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for update-notifier has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.