gnome-twitch crashes when starting a stream

[Jan Morten Rausch]

Gnome-twitch doesn't work on Ubuntu 18.04 as it always crashes when starting a stream. The player backend has no influence over the behaviour.

Example terminal output (personal informations edited out):

[04:43:04] Message - GNOME-Twitch : {GtApp:370} Startup, running version '0.4.1'
[04:43:04] Message - GNOME-Twitch : {GtApp:339} Activate
[04:43:04] Message - GNOME-Twitch : {GtPlayer:132} Loading chat settings
[04:43:04] Message - GNOME-Twitch : {GtPlayer:999} Loaded player backend 'MPV OpenGL player backend'
[04:43:04] Message - GNOME-Twitch : {GtPlayerBackendMpvOpenGL:401} Init
[04:43:04] Message - GNOME-Twitch : {GtApp:147} Succesfully fetched oauth info with name 'xxxxxx', id 'xxxxxxx' and oauth token 'xxxxxxxxxxxxxxxxxxxxx'
[04:43:05] Message - GNOME-Twitch : {GtApp:182} Succesfully fetched user info with name 'xxxxxxx', id 'xxxxxxxx' and oauth token 'xxxxxxxxxxxxxxxxxxxxx'
[04:43:05] Message - GNOME-Twitch : {GtFollowsManager:519} Loaded '21' follows from Twitch
[04:43:06] Message - GNOME-Twitch : {GtPlayer:1310} Opening stream 'ninja' with quality 'source'
[04:43:06] Warning - GNOME-Twitch : {GtTwitch:336} Received unsuccessful response from url 'http://api.twitch.tv/api/channels/ninja/access_token' with code '400' and body '{"error":"Bad Request","status":400,"message":"Requests must be made over SSL"}'
[04:43:06] Warning - GNOME-Twitch : {GtTwitch:594} Error getting stream access token for channel 'ninja' because: Received unsuccessful response from url 'http://api.twitch.tv/api/channels/ninja/access_token' with code '400' and body '{"error":"Bad Request","status":400,"message":"Requests must be made over SSL"}'
Speicherzugriffsfehler (Speicherabzug geschrieben)
####[German for Memory access error]####

[Bin Li (binli)]

Here is the upstream bug.

https://github.com/vinszent/gnome-twitch/issues/356

[Bin Li (binli)]

Here is the patch.

https://github.com/vinszent/gnome-twitch/pull/357/commits/54b210db90e9698da57bed9ceb5119c6b6e5b686?utf8=%E2%9C%93&diff=unified

[Bin Li (binli)]

In debian, it had fixed this issue.

gnome-twitch (0.4.1-3) unstable; urgency=medium

  * Use https to talk to Twitch servers, because
    Twitch deprecated some http APIs (Closes: 898768)
  * Bump standards version from 4.1.1 to 4.1.4.1
  * Bump debhelper compat version to 11

 -- Tim Dengel <email address hidden> Tue, 15 May 2018 21:30:42 +0200

[Bin Li (binli)]

Here is the debian bug.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898768

[Sebastien Bacher (seb128)]

That's fixed in the Debian version which is synced in cosmic

[Sebastien Bacher (seb128)]

SRU uploads to bionic as well

* Impact

The service changed starting refusing non ssl connection, which made the software stop working

* Test case

Start gnome-twitch and try to play some stream

* Regression potential

Check that the service is working

[Łukasz Zemczak (sil2100)]

Hello Jan, or anyone else affected,

Accepted gnome-twitch into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-twitch/0.4.1-2ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Volodymyr Koval (moonflyer)]

The error is still in place, namely

Warning - GNOME-Twitch : {GtTwitch:594} Error getting stream access token for channel 'shroud' because: Received unsuccessful response from url 'http://api.twitch.tv/api/channels/shroud/access_token' with code '400' and body '{"error":"Bad Request","status":400,"message":"Requests must be made over SSL"}'

While parsing the binary to validate that the fix is in place, it became clear that the fix is not complete and at least two URLs are still using HTTP:

/usr/bin$ strings gnome-twitch | grep http
...
https://api.twitch.tv/kraken/streams/followed?limit=%d&offset=%d&oauth_token=%s&stream_type=live
https://api.twitch.tv/kraken/users/%s/follows/channels?limit=%d&offset=%d
http://api.twitch.tv/api/channels/%s/access_token
...
http://api.twitch.tv/api/channels/%s/panels
...

[Volodymyr Koval (moonflyer)]

Sorry, I forgot to write the package version. Also, I seem to be not able to change tags(maybe I am too new to this place).

/usr/bin$ apt list gnome-twitch
gnome-twitch/bionic,now 0.4.1-2 amd64

[Amr Ibrahim (amribrahim1987)]

Please follow the instructions from comment #7 and update to the version in bionic-proposed.

[Sebastien Bacher (seb128)]

installing 0.4.1-2ubuntu0.18.04.1 it plays videos and display chats where the bionic version is segfaulting, marking as verified

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-twitch has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-twitch - 0.4.1-2ubuntu0.18.04.1

---------------
gnome-twitch (0.4.1-2ubuntu0.18.04.1) bionic; urgency=medium

  * Backport the https fix to bionic (lp: #1777049):
    - Use https to talk to Twitch servers, because Twitch deprecated some http
      APIs

 -- Sebastien Bacher <email address hidden> Tue, 03 Jul 2018 10:45:07 +0200