jquery-mobile warnings with jquery 3

Bug #1776816 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

jQuery 3 is deprecating bind and unbind methods. We already have the latest stable version for jquery.mobile.
There is a new alpha version but it doesn't change the touch event code that we actually use for mahara
https://github.com/jquery/jquery-mobile/blame/1.5.0-alpha.1/js/events/touch.js

since it hasn't been change in 2 years, we need to fix this bit of code.

According to the jquery site
https://github.com/jquery/jquery-migrate/blob/master/warnings.md
the solution is to change the method call to use .on() or .off()

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8969

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
status: New → In Progress
milestone: none → 18.10.0
summary: - Update jquery-mobile to 1.5.0-alpha1 for compatibility with jquery 3
+ jquery-mobile warnings with jquery 3
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8977

Changed in mahara:
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8977
Committed: https://git.mahara.org/mahara/mahara/commit/7d09acabc47243b1f4806e661b476e613d132a18
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7d09acabc47243b1f4806e661b476e613d132a18
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Jun 27 14:30:49 2018 +1200

Bug 1776816: Update jquery-mobile - fix bind/unbind

behatnotneeded

Change-Id: I0072124f0f7efa0974fb439ca63daf8495ddac46

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8969
Committed: https://git.mahara.org/mahara/mahara/commit/6213b3d19bb5ad23ef331ed573224c32437a61e6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6213b3d19bb5ad23ef331ed573224c32437a61e6
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jun 21 17:31:31 2018 +1200

Bug 1776816: Update jquery-mobile to 1.5.0-alpha1

for compatibility with jquery 3

behatnotneeded

Change-Id: I5f00e9ff5ec5bcfb9d39abe5c6fd97e3a6e58a33

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.