Line breaks not respected on sendmessage screen for previous message

Bug #1776554 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Rebecca Blundell

Bug Description

When a user sent you a message, you typically click the link in the email to reply. That'll take you to https://DOMAIN/module/multirecipientnotification/sendmessage.php?replyto=IDOFMESSAGE&returnto=inbox

On that screen, you see the message from the user. When they used line / paragraph breaks, they are not visible though making it hard to read the message (see screenshot message_reply.png).

However, when you view the message in your Mahara inbox, it shows the line breaks correctly (see screenshot message_inbox.png).

When a user replies to a message, they should see the line breaks as well.

Tags: bite-sized
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The original message when viewed on the reply screen on sendmessage.php does not respect line breaks, which is not good.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

This is what it should look like instead.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8966

Revision history for this message
Steven (stevens-q) wrote :

Environment tested: Master
Browser tested: Chrome

-------------------------------------
Manual Test Script
-------------------------------------

Preconditions:

1. The following users exist:
a. EarlUser5
b. DanUser4
2. the following relationship exists
a. Earl and Dan are friends

Test Script:

1. DanUser4 logs in and sends messasge to DanUser4 with the following:
a. Subject = Message from Dan to Earl
b. Message = 3 paragraphs with spaces between each paragraph
2. Log in as EarlUser5 and Browse to Inbox | Notifications page
3. Confirm that there is a message from Dan to Earl ✔
4. Open the messsage
5. Confirm that the message body is 3 paragraphs with spaces between each paragraph ✔
6. User click on the reply link at the bottom of the message
7. Confirm that user is redirected to the Send message page ✔
8. Confirm that the original message is displayed above the sendmessage panel ✔
9. Confirm that the message body is 3 paragraphs with spaces between each paragraph ✔

Catalyst QA Approved ✔

Revision history for this message
Steven (stevens-q) wrote :
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8966
Committed: https://git.mahara.org/mahara/mahara/commit/1bab2cb0ee07a2bb55f04dbeec5300e9b1c8f27f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1bab2cb0ee07a2bb55f04dbeec5300e9b1c8f27f
Author: Rebecca Blundell <email address hidden>
Date: Wed Jun 20 12:12:05 2018 +1200

Bug 1776554: Message to reply to should show line breaks

behatnotneeded

Change-Id: If968fc5193faefb97ca14178c29f07618985e978

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.