obsolete code in page custom layout settings

Bug #1775722 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Unassigned

Bug Description

in js/customlayout.js line 225 we have
    $('#togglecustomlayoutoptions').hide();

the element '#togglecustomlayoutoptions' used to contain the "Create custom layout" section in page edit screen, so it could be hidden by clicking on the section title.
 The "Create custom layout" is not hidden anymore, and the element '#togglecustomlayoutoptions' was removed from the html.

The call to $('#togglecustomlayoutoptions').hide() should be removed and also check what other code is not used anymore.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8992

Changed in mahara:
importance: Undecided → Low
milestone: none → 18.10.0
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8992
Committed: https://git.mahara.org/mahara/mahara/commit/bc4b90406bf5617909e795c35d46d734b173a3d4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit bc4b90406bf5617909e795c35d46d734b173a3d4
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 6 15:19:01 2018 +1200

Bug 1775722: remove obsolete code in page custom layout

remove #basiclayouthelp & #customlayouthelp reference

help icons are not used anymore, not even before
unifying the Edit content/Edit layout/Choose skin screens.

remove #createcustomlayouttitle reference

it was used to hide/show the custom layout section
custom layout is not in a collapsible anymore

behatnotneeded

Change-Id: I588ce277370f8e3734b2a43fbc3e5b77c8eae1fb

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.