[SRU] Simbody package ships erroneous paths for blas/lapack in the cmake module

[Jose Luis Rivero]

Affecting Artful:

According to the publishing history, the package Simbody for Artful was directly copied from Zesty: https://launchpad.net/ubuntu/+source/simbody/3.5.4+dfsg-1ubuntu1/+publishinghistory

The problem is that a couple of dependencies of Simbody (libblas and liblapack) changed the location of their libraries to be arch dependent (from /usr/lib to /usr/lib/$arch-triplet/) and these paths are hardcoded by Simbody in the cmake module at building time.

[Impact]

* Any software using Simbody cmake module won't compile because of non existant lib paths in Simbody exported libraries.
  - See https://build.osrfoundation.org/job/gazebo-ci-default-artful-amd64-gpu-none/23/consoleFull#-14256201906ea37b8d-a6d4-40ae-8431-d90c018842af

* Rebuilding the package (binNMU) without any modifications to the source code would make cmake to get the new paths and hardcode them in the cmake module.

[Test Case]

* To check that there are non-existant paths in the current cmake module:

 - apt-get install libsimbody-dev
 - if [[ -f $(sed -n 's:.*\(/usr/.*libblas.so\).*:\1:p' /usr/lib/x86_64-linux-gnu/cmake/simbody/SimbodyConfig.cmake | uniq) ]]; then echo "fixed!"; else echo "Wrong path in cmake module"; fi

* If you run the oneliner in any other release different than Artful it will return a success message.

[Regression Potential]

 * There is no change in code or in Debian metadata, there is a change in the building environment. Changing the build environment from Zesty to Artful could produce some changes in the binary interface but given that it should be its 'native enviroment' I don't expect any incompatibility introduced by the change in the compiler of build flags/libraries.

* The lack of changes in code should keep the API stable.

* The lack of change in debian metadata should keep the packaging stable.

* To minimize the possible problems in the binary interface or any other thing related to the change I created a PPA and rebuild the current version:
  - https://launchpad.net/~j-rivero/+archive/ubuntu/simbody-artful

* I've used Gazebo simulator (which uses Simbody) large test suite for trying to detect possible problems. All seems fine and problems are not related to this bug:
  - https://build.osrfoundation.org/job/gazebo-ci-default-artful-amd64-gpu-none/25/console

* This both shows the SRU team that the risks have been considered, and provides guidance to testers in regression-testing the SRU.

[Other Info]

* I'm currently the maintainer of Simbody in Debian

[Julian Andres Klode (juliank)]

This was fixed in bionic with a no-change rebuild, I just upload one to artful too. Note that we do not have binNMUs, so you probably should have provided a debdiff before subscribing sponsors; but it was OK.

[Brian Murray (brian-murray)]

Hello Jose, or anyone else affected,

Accepted simbody into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/simbody/3.5.4+dfsg-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jose Luis Rivero (j-rivero)]

Thanks Brian for the quick response. I can confirm that the proposed one-liner submitted initially with the bug to check for right paths now returns that the bug is fixed.

I also compiled the gazebo physics suite, that uses the simbody cmake module and the error is now gone.

[Launchpad Janitor (janitor)]

This bug was fixed in the package simbody - 3.5.4+dfsg-1ubuntu1.1

---------------
simbody (3.5.4+dfsg-1ubuntu1.1) artful; urgency=medium

  * No-change rebuild to fix wrong paths in cmake file (LP: #1770678)

 -- Julian Andres Klode <email address hidden> Tue, 15 May 2018 10:41:09 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for simbody has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.