Cisco VTS ML2 missing defaut ip

[Wojciech Dec]

The Cisco ML2 VTS puppet-triple module is missing a default for the VTS IP server address, which is optional. This makes deployments fail on compute nodes where the plugin isn't installed, but the cisco-vts driver is used on the controller.

Steps to reproduce
------------------
Deploy with an env file containing

  OS::TripleO::Services::NeutronCorePlugin: OS::TripleO::Services::NeutronCorePluginVTS

  ## Comment out below line when deploying VTS Agent on compute nodes instead of VPP/VPFA
  OS::TripleO::Services::ComputeNeutronCorePlugin: OS::Heat::None

parameter_defaults:

  VTSUsername: 'admin'
  VTSPassword: 'aaaa'
  VTSServer: 'some.serv'
  VTSVMMID: '1234'

  NeutronMechanismDrivers: 'sriovnicswitch,cisco_vts'

Result
-------
Deployment on compute nodes fails due to vts::vts_ip not being found.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/564352

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564352
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=ffc4ca8e715cf70f165e5d8b4a9cb8d01ecf0f92
Submitter: Zuul
Branch: master

commit ffc4ca8e715cf70f165e5d8b4a9cb8d01ecf0f92
Author: Wojciech Dec <email address hidden>
Date: Wed Apr 25 08:53:44 2018 -0700

    Treat IP address as optional in Cisco VTS ML2 configuration

    Bug #1766949

    Change-Id: I5d8b7f05a2d8d7bff608c8bbe9bd0d837bd1e3dc
    Signed-off-by: Wojciech Dec <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/565660

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/565660
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=d9fe246cff347640c624f9021408f0163d330bed
Submitter: Zuul
Branch: stable/queens

commit d9fe246cff347640c624f9021408f0163d330bed
Author: Wojciech Dec <email address hidden>
Date: Wed Apr 25 08:53:44 2018 -0700

    Treat IP address as optional in Cisco VTS ML2 configuration

    Bug #1766949

    Change-Id: I5d8b7f05a2d8d7bff608c8bbe9bd0d837bd1e3dc
    Signed-off-by: Wojciech Dec <email address hidden>
    (cherry picked from commit ffc4ca8e715cf70f165e5d8b4a9cb8d01ecf0f92)