pyxdg ftbfs: Invalid key: Scale

Bug #1766793 reported by Steve Langasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pyxdg (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[SRU Justification]
pyxdg fails to build because the hicolor theme it tests against now includes new keys that pyxdg doesn't know are valid:

======================================================================
ERROR: test_validate_icon_theme (test-icon.IconThemeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/test/test-icon.py", line 20, in test_validate_icon_them
e
    theme.validate()
  File "/<<PKGBUILDDIR>>/xdg/IniFile.py", line 243, in validate
    raise ValidationError(msg, self.filename)
ValidationError: ValidationError in file '/usr/share/icons/hicolor/index.theme':

- Invalid key: Scale
- Invalid key: Scale
- Invalid key: Scale
- Invalid key: Scale
[...]

  https://launchpad.net/ubuntu/+archive/test-rebuild-20180408/+build/14619155

This makes the package not currently security supportable as of 18.04 release. Since this package is seeded on the desktop image I am not looking to have this included during the freeze but am making it an SRU instead.

[Test case]
If the package builds from source, it has passed its test suite showing that the new code works and is now compatible with current icon themes.

[Regression potential]
In addition to accepting two "new" keys in icon themes, this upload adds two new methods on the IconTheme class. It is possible, but unlikely, that this would confuse downstream consumers of this class who have conflicting usage of methods by these names.

Tags: ftbfs
Steve Langasek (vorlon)
Changed in pyxdg (Ubuntu):
status: New → In Progress
Steve Langasek (vorlon)
tags: added: ftbfs
Revision history for this message
Thomas Kluyver (takluyver) wrote :

This is fixed in PyXDG 0.26 (available from https://pypi.org/project/pyxdg/#files ).

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pyxdg - 0.25-4ubuntu1

---------------
pyxdg (0.25-4ubuntu1) bionic; urgency=medium

  * d/p/0001-Allow-Scale-in-icon-theme-per-directory-sections.patch,
    d/p/0001-Allow-ScaledDirectories-key-in-icon-theme-file.patch:
    cherry-pick upstream support for new keys in icon theme files.
    Closes: #877202, LP: #1766793.

 -- Steve Langasek <email address hidden> Tue, 24 Apr 2018 22:49:45 -0700

Changed in pyxdg (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.