libcommons-lang3-java causes NullPointer in surefire/javadoc

[Tiago Stürmer Daitx]

libcommons-lang3-java requires a patch to work with openjdk-10, without it any packages that depend on it on runtime will fail with a NullPointerException - specially libmaven-javadoc-plugin-java (doc generation) and libsurefire-java (tests), which are used by most (if not all) maven dependent builds, thus a lot of stuff fails.

As the libcommons-lang3-java build itself depends on both libmaven-javadoc-plugin-java and libsurefire-java, there's a 3 step to get a build working:
1) build libcommons-lang3-java patched for openjdk-10 (with docs and tests disabled)
2) rebuild surefire (for some reason it embeds libcommons-lang3-java code during build time instead of relying on the system dependency)
3) rebuild libcommons-lang3-java patched for openjdk-10

The resulting debian binary package from each step must be included in the next build steps: step #2 requires the binary from #1; step #3 requires the binaries from #1 and #2.

[Tiago Stürmer Daitx (tdaitx)]

This patch allows libcommons-lang3-java to be build with openjdk-10 by overriding and disabling tests, docs, and doc package install. It also applies 2 required patches to fix:

1) a NullPointerException when the resulting binaries are run with openjdk-10
2) a missing 3 area code locale support

After applying this patch surefire can be rebuild and - after that - the build/test/install overrides from this patch can be removed in order to finally rebuild libcommons-lang3-java.

[Tiago Stürmer Daitx (tdaitx)]

As of now there are 14 java related failures in update excuses [1] that will be fixed by getting this bug fixed:

- activemq
- csvjdbc
- easymock
- gradle
- jboss-logmanager
- jboss-modules
- jsoup
- jug
- libcommons-compress-java
- libcommons-lang3-java
- libcommons-validator-java
- libgoogle-gson-java
- libhibernate3-java
- libpdfbox2-java

and will prevent more showing up as anything that uses javadoc or surefire in maven is bound to fail without this 3 step fix.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libcommons-lang3-java - 3.5-2ubuntu1

---------------
libcommons-lang3-java (3.5-2ubuntu1) bionic; urgency=medium

  * debian/patches/fix-openjdk-10-nullpointer-lang-1365.diff: calls to
    org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast cause
    NullPointerException when running under openjdk-10 which in turn causes
    other packages to FTBFS with the message "Execution default-cli of goal
    groupId:artifactId:version:jar failed.: NullPointerException -> [Help 1]".
    LP: #1765570. (Closes: #895234)
  * debian/patches/fix-numeric-3-area-code-support-lang-1312.diff: pull
    upstream fix for numeric-3 area code support. (Closes: #895583)

 -- Tiago Stürmer Daitx <email address hidden> Fri, 20 Apr 2018 01:43:40 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package surefire - 2.20.1-3build1

---------------
surefire (2.20.1-3build1) bionic; urgency=medium

  * Rebuild against new libcommons-lang3-java (LP: #1765570)

 -- Adam Conrad <email address hidden> Fri, 20 Apr 2018 07:58:56 -0600