Comments can't be deleted when work is submitted for marking

[Kevin Dibble]

Version: Mahara 18.04.0
Os: Mac
Database: mysql
Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

Issue:
When work is submitted for Marking, all comments and feedback during the marking process can be deleted by the user.

Possible solution:
While work is locked, to hide the delete comment form for annotation comments (Smart evidence feedback) and to check if work is in a submitted state before deleting page comments.

Users can still show/hide comments from public as needed. Creators of comments can still edit them (during the edit timeframe), but will not be able to delete them while the page is under review.

Attached is a patch with this possible solution.

[Kristina Hoeppner (kris-hoeppner)]

Hi Kevin. Thank you very much for the patch. We will put it into our code review system https://reviews.mahara.org Can you please send me your email address so we can credit you as author?

If you like, you can put future changes and new features directly into the code review system yourself: https://wiki.mahara.org/wiki/Developer_Area/Contributing_Code

[Kevin Dibble (digitalskill)]

Thanks Kristina,

My email address is: <email address hidden>

Cheers team,

Kevin

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8810

[Steven (stevens-q)]

Launchpad: https://bugs.launchpad.net/mahara/+bug/1763517
Gerrit: https://reviews.mahara.org/#/c/8810/
Bug description: Comments can't be deleted when work is submitted for marking
--------------------------------------------------------------
Environment tested: Master
Browser tested: Chrome

===================
Acceptance Criteria:

1. While work is locked, to hide the delete comment form for annotation comments (Smart evidence feedback) and to check if work is in a submitted state before deleting page comments.
2. Users can still show/hide comments from public as needed
3. Creators of comments can still edit them (during the edit time frame), but will not be able to delete them while the page is under review
===================
Manual Test Script
===================

Preconditions:
1. User5 exists and is a member of Group 101
2. Portfolio page exists as follows
 a. title = work submitted for Marking
 b. Allow comments = Yes
 c. SHARED WITH = Public
3. Group 101 exists
4. User6 has made 2 comments on User5's page "
work submitted for Marking"
6. User5 has made a comment on User5's page "work submitted for Marking"

Test Script:
1. log in as User5
2. Browse to Main menu > Portfolio > Pages and collections - "work submitted for Marking"
3. Confirm that user cannot edit Page content ✔
4. Confirm that user can see the previous comments displayed ✔
5. Confirm that user can not see detele comment icon ✔
6. Log in as User6 and make a comment on User5's page "work submitted for Marking"
7. Confirm that users can still make comments to work that has been submitted for Marking ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8810
Committed: https://git.mahara.org/mahara/mahara/commit/65475755b51c9d03150a814d38aedfa92a15d9aa
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 65475755b51c9d03150a814d38aedfa92a15d9aa
Author: Kevin Dibble <email address hidden>
Date: Mon Apr 16 10:25:12 2018 +1200

Bug 1763517: Comments can't be deleted when work is submitted for marking

behatnotneeded

Change-Id: I402d90f2e89466aa266b28451b7511ba35a2305a