INTERFACE_MAX is not proper

[Fabio Massimo Di Nitto]

Binary package hint: openais

Description of problem:

exec/totem.h defines INTERFACE_MAX to 2. This is very limiting and it is not
coherent with the rest of the cluster stack.

openais limits to 2
kernel dlm to 3
dlm_controld to 4

Those values should be at least alligned to 4 or higher.

In theory a dynamic allocation here would be the winner.

with the default set to 2, configuring 3 rings in openais.conf (passive mode,
since active it totally broken), will lead openais to crash because of memory
corruption (there is no protection within the code to try to init and config
only INTERFACE_MAX).

Version-Release number of selected component (if applicable):

trunk

How reproducible:

always

Steps to Reproduce:
1. given default svn checkout
2. configure INTERFACE_MAX + 1 rings in passive mode
3. fire up aisexec.

(tested on amd64 with glibc-2.7 will report memory corruption detected by glibc)

Actual results:

aisexec crashes and dies.

Expected results:

should work no matter how many rings i configure. hardcoded limitations are bad
and it is not even documented.

Additional info:

[Fabio (fabio-redhat-bugs)]

Description of problem:

exec/totem.h defines INTERFACE_MAX to 2. This is very limiting and it is not
coherent with the rest of the cluster stack.

openais limits to 2
kernel dlm to 3
dlm_controld to 4

Those values should be at least alligned to 4 or higher.

In theory a dynamic allocation here would be the winner.

with the default set to 2, configuring 3 rings in openais.conf (passive mode,
since active it totally broken), will lead openais to crash because of memory
corruption (there is no protection within the code to try to init and config
only INTERFACE_MAX).

Version-Release number of selected component (if applicable):

trunk

How reproducible:

always

Steps to Reproduce:
1. given default svn checkout
2. configure INTERFACE_MAX + 1 rings in passive mode
3. fire up aisexec.

(tested on amd64 with glibc-2.7 will report memory corruption detected by glibc)

Actual results:

aisexec crashes and dies.

Expected results:

should work no matter how many rings i configure. hardcoded limitations are bad
and it is not even documented.

Additional info:

[Soren Hansen (soren)]

openais (0.82-0ubuntu7) hardy; urgency=low

  [ Fabio M. Di Nitto ]
  * Update to SVN trunk in preparation of 0.83.
  * rediff all patches.

  [ Soren Hansen ]
  * 004_increase_max_rings.dpatch: Increase INTERFACE_MAX to 4 (LP: #176299)
    Thanks Fabio!

 -- Soren Hansen <email address hidden> Fri, 14 Dec 2007 09:34:53 +0100

[Lon (lon-redhat-bugs)]

*** Bug 424671 has been marked as a duplicate of this bug. ***

[Fabio (fabio-redhat-bugs)]

The cman crash has been fixed.

Time to address the inconsistency.

Fabio

[Steven (steven-redhat-bugs)]

breaks compatability will not be changed in rhel5.

[Fabio (fabio-redhat-bugs)]

It does not need to be fixed in rhel5 but can be done in trunk and forward releases.