Sync golang-golang-x-sys 0.0~git20180224.f6cff07-1 (universe) from Debian unstable (main)

[Anthony Fok]

Dear Release Team,

As reported in Debian Bug #891894 "redefinition of 'SyscallNoError' when building with gccgo 8" at https://bugs.debian.org/891894, packages using an older version of golang-golang-x-sys-dev (src:golang-golang-x-sys) such as 0.0~git20170727.0.35ef448-2 would FTBFS when built with gccgo-8.

Example with golang-github-alecthomas-chroma:
  https://buildd.debian.org/status/logs.php?pkg=golang-github-alecthomas-chroma&ver=0.3.0-1&arch=ppc64

  * Before (Failed):
    https://buildd.debian.org/status/fetch.php?pkg=golang-github-alecthomas-chroma&arch=ppc64&ver=0.3.0-1&stamp=1519972270&raw=0

  * After (Successful):
    https://buildd.debian.org/status/fetch.php?pkg=golang-github-alecthomas-chroma&arch=ppc64&ver=0.3.0-1&stamp=1520253070&raw=0

This was fixed upstream in https://github.com/golang/sys/commit/37707fdb30a5b38865cfb95e5aab41707daec7fd

  unix: move gccgo redeclared *SyscallNoError functions to a separate file

  Same as CL 34379, SyscallNoError and RawSyscallNoError are redeclared
  for gccgo builds since CL 85756. Thus, move the declarations to a gc
  specific file.

And this fix is included in golang-golang-x-sys 0.0~git20180224.f6cff07-1:

  golang-golang-x-sys (0.0~git20180224.f6cff07-1) unstable; urgency=medium

    * New upstream version, which has gccgo redeclared *SyscallNoError
      functions moved to a separate file and avoids build error with gccgo-8.
      Many thanks to Shengjing Zhu for the detailed report. (Closes: #891894)

   -- Anthony Fok <email address hidden> Thu, 01 Mar 2018 23:43:02 -0700

Many thanks!

[Michael Hudson-Doyle (mwhudson)]

This bug was fixed in the package golang-golang-x-sys - 0.0~git20180224.f6cff07-1

---------------
golang-golang-x-sys (0.0~git20180224.f6cff07-1) unstable; urgency=medium

  * New upstream version, which has gccgo redeclared *SyscallNoError
    functions moved to a separate file and avoids build error with gccgo-8.
    Many thanks to Shengjing Zhu for the detailed report. (Closes: #891894)

 -- Anthony Fok <email address hidden> Thu, 01 Mar 2018 23:43:02 -0700

[Michael Hudson-Doyle (mwhudson)]

I'm going to put my golang maintainer hat on and say this doesn't require a FFe, so I've done the sync. Note that the previous version of golang-golang-x-sys was stuck in proposed and so this version might need some hand holding to migrate. Are you willing/able to help with that?

[Anthony Fok (foka)]

> I'm going to put my golang maintainer hat on and say this doesn't require a FFe,
> so I've done the sync.

Woohoo! Thank you *so* much, Michael!

> Note that the previous version of golang-golang-x-sys was stuck in proposed
> and so this version might need some hand holding to migrate.
> Are you willing/able to help with that?

Yes! It is my pleasure and honour! Do you mean that I should monitor

    http://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html

and check what is holding golang-golang-x-sys back, and try to fix them from Debian's, and then use requestsync to get them into bionic so that golang-golang-x-sys 0.0~git20180224.f6cff07-1 could migrate from "proposed" into "release" smoothly?

The above is what I just learned earlier today, so I hope I am understanding the process correctly. ;-)

Cheers!

[Michael Hudson-Doyle (mwhudson)]

On 7 March 2018 at 10:40, Anthony Fok <email address hidden> wrote:

> > I'm going to put my golang maintainer hat on and say this doesn't
> require a FFe,
> > so I've done the sync.
>
> Woohoo! Thank you *so* much, Michael!
>
> > Note that the previous version of golang-golang-x-sys was stuck in
> proposed
> > and so this version might need some hand holding to migrate.
> > Are you willing/able to help with that?
>
> Yes! It is my pleasure and honour! Do you mean that I should monitor
>
> http://people.canonical.com/~ubuntu-archive/proposed-
> migration/update_excuses.html
>
> and check what is holding golang-golang-x-sys back, and try to fix them
> from Debian's, and then use requestsync to get them into bionic so that
> golang-golang-x-sys 0.0~git20180224.f6cff07-1 could migrate from
> "proposed" into "release" smoothly?
>

Yes, more or less. The hard part is usually figuring out what's going on
more than fixing the problems so assistance on that part is what's most
needed. It looks like SetAffinity is broken on arm64 in the new version and
in fact was probably broken already in
golang-golang-x-sys/0.0~git20180126.0.ff2a66f-1 ... which was the version
that added SetAffiinity at all so it's probably always been broken... which
probably means an upstream bug report...

etc etc :)

> The above is what I just learned earlier today, so I hope I am
> understanding the process correctly. ;-)
>
> Cheers!
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1753748
>
> Title:
> Sync golang-golang-x-sys 0.0~git20180224.f6cff07-1 (universe) from
> Debian unstable (main)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/golang-golang-
> x-sys/+bug/1753748/+subscriptions
>

[Michael Hudson-Doyle (mwhudson)]

On 7 March 2018 at 14:59, Michael Hudson-Doyle <<email address hidden>
> wrote:

>
> Yes, more or less. The hard part is usually figuring out what's going on
> more than fixing the problems so assistance on that part is what's most
> needed. It looks like SetAffinity is broken on arm64 in the new version and
> in fact was probably broken already in
> golang-golang-x-sys/0.0~git20180126.0.ff2a66f-1 ... which was the version
> that added SetAffiinity at all so it's probably always been broken... which
> probably means an upstream bug report...
>

Actually I'm very very confused by this. I can't reproduce it on the porter
box, maybe it only happens in a VM (which is what the autopkgtest run in)
for some reason. If you have access to a vm on arm64 ...

golang-github-prometheus-tsdb is just a flaky test I think. I'll bounce on
retry a few times and get it marked as bad if it doesn't pass.

[Anthony Fok (foka)]

> It looks like SetAffinity is broken on arm64 in the new version and
> in fact was probably broken already in
> golang-golang-x-sys/0.0~git20180126.0.ff2a66f-1 ... which was
> the version that added SetAffiinity at all so it's probably always
> been broken... which probably means an upstream bug report...

I think you are right: the SchedSetaffinity stuff was added recently
on 2018-01-05, and here are links to the upstream GitHub issue and
code review:

 * x/sys/unix: add sched_getaffinity/sched_setaffinity
   https://github.com/golang/go/issues/11243

 * unix: add SchedGetaffinity and SchedSetaffinity on Linux
   https://go-review.googlesource.com/c/sys/+/85915

> Actually I'm very very confused by this.
> I can't reproduce it on the porter box, maybe it
> only happens in a VM (which is what the autopkgtest run in)
> for some reason. If you have access to a vm on arm64 ...

Unfortunately, I don't have access to a VM on arm64 either...
or perhaps I could follow https://wiki.ubuntu.com/ARM64/QEMU
and see if it can be reproduced with qemu-system-aarch64
running on my x86 (amd64) host? :-D

Anyhow, I'll collect more information and file an upstream bug soon.

[Michael Hudson-Doyle (mwhudson)]

On 7 March 2018 at 16:10, Michael Hudson-Doyle <<email address hidden>
> wrote:

> On 7 March 2018 at 14:59, Michael Hudson-Doyle <
> <email address hidden>> wrote:
>
>>
>> Yes, more or less. The hard part is usually figuring out what's going on
>> more than fixing the problems so assistance on that part is what's most
>> needed. It looks like SetAffinity is broken on arm64 in the new version and
>> in fact was probably broken already in
>> golang-golang-x-sys/0.0~git20180126.0.ff2a66f-1 ... which was the
>> version that added SetAffiinity at all so it's probably always been
>> broken... which probably means an upstream bug report...
>>
>
> Actually I'm very very confused by this. I can't reproduce it on the
> porter box, maybe it only happens in a VM (which is what the autopkgtest
> run in) for some reason. If you have access to a vm on arm64 ...
>

I figured this one out: https://go-review.googlesource.com/c/sys/+/99355.
Do you want to care of uploading yet another snapshot to debian so I can
sync it? Or would you prefer me to?

[Anthony Fok (foka)]

On Wed, Mar 7, 2018 at 8:05 PM, Michael Hudson-Doyle <email address hidden> wrote:
> I figured this one out: https://go-review.googlesource.com/c/sys/+/99355.

You are *really* awesome!

> Do you want to care of uploading yet another snapshot to debian
> so I can sync it? Or would you prefer me to?

My pleasure! golang-golang-x-sys (0.0~git20180308.349b81f-1)
has been uploaded to Debian unstable, see the new sync request at:

https://bugs.launchpad.net/bugs/1754233