Mahara

SAML has "Parent authority" field that shouldn't be there

Bug #1753041 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 18.04.0

Bug Description

18.04 master

SAML auth shows the "Parent authority" field above the "Login error message" field. SAML can't have a parent authority though. It can only be a parent authority. This field should be removed and the "Login error message" field should receive a proper label so people know what it is about and not only have the title show in the help text.

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8574

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8574
Committed: https://git.mahara.org/mahara/mahara/commit/74327f49294b5df1e984cbd2e7be266b5ee44aa6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 74327f49294b5df1e984cbd2e7be266b5ee44aa6
Author: Robert Lyon <email address hidden>
Date: Tue Mar 6 13:32:25 2018 +1300

Bug 1753041: Allow auth message without parent option for SAML config

Also add label field for auth message for both saml and xmlrpc

behatnotneeded

Change-Id: I4f5f887ba48c26dce92b69eda0f03a7fa761c78d
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.