undercloud.conf requires a [ctplane-subnet] section

[James Slagle]

Since https://review.openstack.org/#/c/533365 landed,
you are required to have a [ctplane-subnet] section in your undercloud config, otherwise you can get a "None" value rendered in the hieradata file.

For example, a minimal config for undercloud.conf where you only overrode specific values used to work:

~~~~
[DEFAULT]
net_config_override = net-config-override.json
~~~~

Now, at a minimum, this is requred:

~~~~
[DEFAULT]
net_config_override = net-config-override.json

[ctlplane-subnet]
~~~~

Perhaps there is an option in oslo.cfg to make a section assumed to be present by default.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/548061

[Ben Nemec (bnemec)]

I think instack-undercloud is incorrectly doing the config initialization in such a way that the dynamically registered opts are getting wiped out, but I'm going to leave this open against oslo.config too until we verify.

[Harald Jensås (harald-jensas)]

Which value is rendered to None?

I tried to reproduce this with the undercloud.conf below, and I don't see the issue? Undercloud installs, and thinks look ok.

[stack@bug1751815 ~]$ rpm -q instack-undercloud
instack-undercloud-8.2.1-0.20180220181914.529796b.el7.centos.noarch

[stack@bug1751815 ~]$ cat undercloud.conf
[DEFAULT]

undercloud_hostname = bug1751815.lab.example.com

net_config_override = net-config-override.json

[stack@bug1751815 ~]$ cat net-config-override.json
"network_config": [
 {
  "type": "ovs_bridge",
  "name": "br-ctlplane",
  "ovs_extra": [
   "br-set-external-id br-ctlplane bridge-id br-ctlplane"
  ],
  "addresses": [
    {
      "ip_netmask": "{{PUBLIC_INTERFACE_IP}}"
    }
  ],
  "routes": {{SUBNETS_STATIC_ROUTES}},
  "mtu": {{LOCAL_MTU}}
}
]

[stack@bug1751815 ~]$ sudo grep -R none /etc/puppet/hieradata/
[stack@bug1751815 ~]$ sudo grep -R None /etc/puppet/hieradata/

5: br-ctlplane: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN qlen 1000
    link/ether f2:dc:59:34:0e:41 brd ff:ff:ff:ff:ff:ff
    inet 192.168.24.1/24 brd 192.168.24.255 scope global br-ctlplane
       valid_lft forever preferred_lft forever
    inet6 fe80::f0dc:59ff:fe34:e41/64 scope link
       valid_lft forever preferred_lft forever

[root@bug1751815 ~]# json_reformat < /etc/os-net-config/config.json
{
    "network_config": [
        {
            "addresses": [
                {
                    "ip_netmask": "192.168.24.1/24"
                }
            ],
            "mtu": 1500,
            "ovs_extra": [
                "br-set-external-id br-ctlplane bridge-id br-ctlplane"
            ],
            "routes": [

            ],
            "type": "ovs_bridge",
            "name": "br-ctlplane"
        }
    ]
}

#############################################################################
Undercloud install complete.

[James Slagle (james-slagle)]

i can't seem to reproduce this any longer, so marking invalid for now

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/548061
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=0497316fae160e5aaa59887bad1ad06a40f7088a
Submitter: Zuul
Branch: master

commit 0497316fae160e5aaa59887bad1ad06a40f7088a
Author: Ben Nemec <email address hidden>
Date: Mon Feb 26 16:17:53 2018 +0000

    Don't double load config

    This isn't necessary and will likely have some bad side effects
    because re-calling the conf object clears all previously registered
    opts, which defeats the purpose of the second call.

    Change-Id: I59bd78e85b3d55aea23b46809f4de678d394f66d
    Related-Bug: 1751815