Notifications still sent out to suspended accounts

[Kristina Hoeppner]

Noticed on Mahara 17.10: When an account is suspended, but the user has subscribed to forums, the user still receives notifications.

I think it would be better if no notifications are sent when an account is suspended as it is in the stage right before removal. It would need to be checked if other notifications are also still sent to suspended users.

When an account is suspended, the user should not be allowed to have any interactions on the site as they cannot log into the site. That would then also for for notifications.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8807

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8807
Committed: https://git.mahara.org/mahara/mahara/commit/2689653233113b5d66532cb5b315c440b1946d96
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2689653233113b5d66532cb5b315c440b1946d96
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 19 14:47:41 2018 +1200

Bug 1751688: Prevent sending notifications to suspended users

Prevent sending any notifications to a suspended user
except for the ones sent when they are being suspended/unsuspended.

behatnotneeded

Change-Id: I197a3c17af13413c1147ae56925f7b161615fb9b