web client: type to select wonky in item stat cat dropdowns

[Andrea Neiman]

(Related bug 1751353 is for patron stat cats)

XUL client has type-to-select for stat cats in both the item editor & patron editor.

In the web client item editor, this still exists but works a little wonkily. It doesn't show the characters as you type, and it only seems to work if a stat cat value is unset or reset back to no value.

[Erica Rohlfs (erohlfs)]

I tested on 3.0.3. When testing, I cannot recreate this behavior for patron stat cats, even with the caveat of unset value and/or reset back to no value. What I'm observing is the inability to type-to-select without any additional selection being made. I tested both registering a patron and an existing patron account. Within the item editor, however, I am seeing the behavior you mention on item stat cats. What I see is that, instead of the filtering options populating, the select option jumps down to the beginning of the letter typed. For example, if I type "k" in the item stat cat dropdown, it will jump down to the start of k's in my list, such as kit. I see similar behavior in other interfaces not related to stat cats, such as typing "k" to select through all of the different libraries starting with k when selecting a pickup library location. My best description of the behavior is like that of a "Find on this Page" feature and less like a filter.

[Remington Steed (rjs7)]

For anyone who wants to work on this, it sounds like the Stat Cat dropdown needs to be replaced with an eg-basic-combo-box. See bug #1793196 for one example of how this can be done.

[Mike Risher (mrisher)]

The item stat cat dropdown is now using an eg-basic-combo-box. Here is the branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1751356-item-stat-cat-dropdowns

Please note that eg-basic-combo-box has issues with filtering, which have been reported here:
https://bugs.launchpad.net/evergreen/+bug/1819233

[Rogan Hamby (rogan-hamby)]

sign off pushed to user/rogan/lp1751356_signoff

[Galen Charlton (gmc)]

This needs a bit more work, as it breaks the statcat dropdown when using the volcopy editor to edit an item template rather than an item.

[Mike Risher (mrisher)]

Thanks for the feedback Galen. The dropdowns are now working properly on the item template. Also, during testing I came across a scenario where the end user switches from a saved value for a stat cat to no saved value. To indicate no selection I added the entry "<NONE>". This is consistent with with the text on other fields that are unset.

Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1751356-item-stat-cat-dropdowns

[Jennifer Bruch (jbruchpails)]

Any chance this fix can be applied to the Patron Stat Cats as well?

(Related bug 1751353 is for patron stat cats)

[Christine Burns (christine-burns)]

I have tested this code and consent to signing off on it with my name, Christine Burns and my email address, <email address hidden>."

https://terran-master.gapines.org/eg/staff/

[Jane Sandberg (sandbergja)]

With appreciation to Mike and Christine, I am marking this as Won't Fix, since it doesn't appear to be an issue in the Angular holdings editor.