Web Client: egBasicComboBox problems filtering choices when typing (i.e. autosuggest)

[Remington Steed]

Our AngularJS directive "egBasicComboBox" has some buggy behavior when it attempts to filter the options list based on what you type into the textbox.

This editable dropdown is used in multiple places in the web client. For example, on the Item Editor, this combobox is used for the Template selector. Also, bug 1793196 will use this combobox in the Volume Editor for the batch Call Number dropdown.

Examples of buggy behavior:

- Typing certain characters causes console errors, such as square bracket "["
- In the batch Call Number dropdown (as added in bug 1793196), typing a matching string (which should show choices) only displays an empty list of choices (a tiny white popup)

[Mike Risher (mrisher)]

I think I found the filtering bug. If you have an open list of values, then click on the caret ^ button to close the list it all works fine. However, if you close the list by clicking on the text input box, the list closes but filtering stops working properly. I fixed this bug. Also, it no longer shows console errors when values like [ are typed. It's no longer case sensitive. Typing "t" will match with "Tuesday", for example. Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1819233-eg-combo-box-filtering

[Terran McCanna (tmccanna)]

This works for me!

My sign off is at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1819233-eg-combo-box-filtering-signoff

[Galen Charlton (gmc)]

Tested and pushed down to rel_3_7. Thanks, Mike and Terran!