strongswan: New upstream release 4.1.9

[R. Pereira Braga]

Binary package hint: strongswan

Package: strongswan
Version: 4.1.9
Severity: wishlist

I'm attaching the source package.

[Siegfried Gevatter (rainct)]

Thanks for contributing to Ubuntu!

Could you please provide a interdiff? You will find more information on how to do this here: https://wiki.ubuntu.com/MOTU/Contributing

[Daniel Holbach (dholbach)]

Rodrigo: good work. Can you make sure your package adheres to http://wiki.ubuntu.com/DebianMaintainerField ?

[Daniel Holbach (dholbach)]

Just re-upload .diff.gz and .dsc

Siegfried: are we sure that a debdiff / interdiff is interesting in this scenario (package update)?

[Daniel Holbach (dholbach)]

The old version contains the following change in the.diff.gz:

--- strongswan-4.1.8.orig/src/starter/lex.yy.c
+++ strongswan-4.1.8/src/starter/lex.yy.c
@@ -1186,7 +1186,7 @@

                /* Read in more data. */
                YY_INPUT( (&YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[number_to_move]),
- (yy_n_chars), num_to_read );
+ (yy_n_chars), (size_t) num_to_read );

                YY_CURRENT_BUFFER_LVALUE->yy_n_chars = (yy_n_chars);
                }
@@ -1500,19 +1500,9 @@
        yyfree((void *) b );
 }

-#ifndef _UNISTD_H /* assume unistd.h has isatty() for us */
-#ifdef __cplusplus
-extern "C" {
-#endif
-#ifdef __THROW /* this is a gnuism */
-extern int isatty (int ) __THROW;
-#else
+#ifndef __cplusplus
 extern int isatty (int );
-#endif
-#ifdef __cplusplus
-}
-#endif
-#endif
+#endif /* __cplusplus */

 /* Initializes or reinitializes a buffer.
  * This function is sometimes called more than once on the same buffer,
@@ -1700,7 +1690,7 @@

 /** Setup the input buffer state to scan a string. The next call to yylex() will
  * scan from a @e copy of @a str.
- * @param str a NUL-terminated string to scan
+ * @param yystr a NUL-terminated string to scan
  *
  * @return the newly allocated buffer state object.
  * @note If you want to scan bytes that may contain NUL values, then use

You seem to drop it. Is it still necessary? Unfortunately it was never explicitly mentioned in debian/changelog, it seems.

[Siegfried Gevatter (rainct)]

I don't know, it's what the wiki says... After commenting on this bug I asked in #ubuntu-motu and they told me that both are OK but an interdiff is prefered as the orig tarball wastes Launchpad space...

Sorry if this comment was inappropriate.

[Daniel Holbach (dholbach)]

No that's fine, Siegfried. Maybe I'm just not used to the interdiff usage yet.

[Emmet Hikory (persia)]

Thanks for the update. I've unsubscribed ubuntu-universe-sponsors, as there's a little work remaining to be done, as follows: Firstly, you'll want to use "XSBC-Original-Maintainer" in place of "Debian-Maintainer" in debian/control. Secondly, It would be nice if you closed this bug in the changelog with LP: 175018. The "dropped patch" looks fine, as it has been accepted upstream. Please resubscribe ubuntu-universe-sponsors once a new interdiff has been attached.

[Daniel Holbach (dholbach)]

Closes: #175018 -> (LP: #175018) next time, apart from that good work! Uploaded.