[2.3, UI, UX, HWTv2] No confirmation message is asked when attempting to run hardware tests on deployed machines
Bug #1750160 reported by
Nusrath Mohammed
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Lee Trager | ||
2.3 |
Fix Released
|
High
|
Lee Trager |
Bug Description
No warning is given when attempting to run hardware tests on Live Production nodes.
- There was no warning given when the engineer accidentally selected live production nodes to run hardware tests (cpu / memory stress tests)
- A warning before such actions could help in avoiding unintentional actions on live nodes.
Related branches
~mpontillo/maas:preseed-per-interface-routes--bug-1758919--2.3
Superseded
for merging
into
maas:master
- MAAS Maintainers: Pending requested
-
Diff: 1785 lines (+1501/-2) (has conflicts)17 files modifieddebian/changelog (+10/-0)
snap/snapcraft.yaml (+9/-0)
src/maasserver/bootsources.py (+3/-0)
src/maasserver/models/tests/test_userprofile.py (+3/-0)
src/maasserver/rpc/boot.py (+5/-0)
src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+17/-0)
src/maasserver/static/partials/ipranges.html (+17/-0)
src/maasserver/static/partials/node-details.html (+134/-0)
src/maasserver/static/partials/nodes-list.html (+1017/-0)
src/maasserver/static/partials/script-results-list.html (+76/-0)
src/maasserver/tests/test_bootsources.py (+3/-0)
src/maasserver/triggers/tests/test_websocket_listener.py (+5/-0)
src/provisioningserver/import_images/boot_resources.py (+61/-0)
src/provisioningserver/import_images/tests/test_boot_resources.py (+92/-0)
src/provisioningserver/import_images/tests/test_download_resources.py (+35/-0)
src/provisioningserver/utils/tests/test_network.py (+3/-0)
utilities/release-build (+11/-2)
~ltrager/maas:lp1750160_2.3
- Lee Trager (community): Approve
-
Diff: 265 lines (+105/-7)6 files modifiedsrc/maasserver/static/js/angular/controllers/node_details.js (+10/-1)
src/maasserver/static/js/angular/controllers/nodes_list.js (+27/-4)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+22/-0)
src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+28/-0)
src/maasserver/static/partials/node-details.html (+9/-1)
src/maasserver/static/partials/nodes-list.html (+9/-1)
~ltrager/maas:lp1750160
Merged
into
maas:master
- Blake Rouse (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 268 lines (+109/-6)6 files modifiedsrc/maasserver/static/js/angular/controllers/node_details.js (+10/-1)
src/maasserver/static/js/angular/controllers/nodes_list.js (+27/-4)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+22/-0)
src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+28/-0)
src/maasserver/static/partials/node-details.html (+11/-0)
src/maasserver/static/partials/nodes-list.html (+11/-1)
Changed in maas: | |
status: | New → Incomplete |
summary: |
- No warning is given when attempting to run hardware tests on Live - Production nodes + [2.3] No confirmation message is asked attempting to run hardware tests + on deployed machines |
Changed in maas: | |
assignee: | nobody → Lee Trager (ltrager) |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.4.x → 2.4.0alpha2 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi,
While I agree it would be nicer to have a warning when trying to test a deployed machine, could you please share a bit more what your expectation is or what problem you actually got?
Did you attempted to run hardware tests on the specific machine from the Machine details page, or were you trying to run hardware tests on multiple machines from the Node listing page?