i18n: <IP address> on subnet <subnet> is hard to translate

[Akihiro Motoki]

In "Parent Port" and "Sub Ports" tabs of "Create Trunk" / "Edit Trunk" form, the "IP" column of the port table contains information of the format of "<IP address> on subnet <subnet>", but it is difficult to translate considering the word order because only "on subnet" is marked as translation string.

Also, "<IP address> on subnet <subnet>" in network ports" tab in the "Create Instance" workflow is not marked as translation string.

Angular gettext supports "Translate parameters" feature [1]. By using this, we can support the word order in translation.

[1] https://angular-gettext.rocketeer.be/dev-guide/translate-params/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/538676

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/538676
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=49fd528b7b814e8e8dab1fb238a79924fbf059b7
Submitter: Zuul
Branch: master

commit 49fd528b7b814e8e8dab1fb238a79924fbf059b7
Author: Akihiro Motoki <email address hidden>
Date: Mon Jan 29 05:45:00 2018 +0900

    i18n: Allow translator to control the word order (trunk)

    "<IP address> on subnet <subnet>" format in "Parent Port" and
    "Subports" tabs in "Create Trunk" and "Edit Trunk" form did not
    allow translators to control the word order because only "on subnet"
    was marked as translation string and they are concatenated.

    This commit improves the translation string by using the "translate
    parameters" feature of Angular gettext.

    Also "on subnet" in the "Network Ports" tab of "Create Instance"
    workflow is now marked as translation string.

    Change-Id: I189897eee8037466ace2b68b8f9be3dc242c4252
    Closes-Bug: #1745873

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/539528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539528
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=62944941630bc5842213b8dadc8da5af62557143
Submitter: Zuul
Branch: master

commit 62944941630bc5842213b8dadc8da5af62557143
Author: Akihiro Motoki <email address hidden>
Date: Wed Jan 31 22:00:04 2018 +0900

    i18n: Fix untranslated messages

    trunk-subports.help.html: The <p translate> tag was not closed
    appropriately. This confused angular-gettext and as a result
    translations are not used properly.

    launch-instance/networkports/ports.html:
    "on subnet" was marked as translation string in bug 1745873,
    but one "on subnet" is forgot to mark. This commit fixes it.

    Related-Bug: #1745873
    Change-Id: I01c653161c9a91d499bf493590bb5f511901f31a

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0rc1 release candidate.