Decorations/headerbars are broken: double bar in Xorg logins and missing in Wayland logins

[Khurshid Alam]

Decorations/headerbars are broken: double bar in Xorg logins and missing in Wayland logins.

The session detection for gtk3-nocsd doesn't work properly as it still uses old session detection method of gnomerc. It tries to detect the session by shipping 51gtk3-nocsd-detect in /etc/X11/Xsession.d.

51gtk3-nocsd-detect uses:

1) `BASESTARTUP=${STARTUP%% *}` which fails as STARTUP was never set on Ubuntu

2) `BASESTARTUP=$(basename $(readlink /etc/alternatives/x-session-manager))` which will fail(it never goes into the inner loop due to previous error) for unity session as unity session also uses gnome-session but wants to set GTK_CSD=0 globally.

The modern way to detect session is to use $XDG_CURRENT_DESKTOP variable. I attached a patch which takes advantage of that.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "improve-session-detection.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Daniel van Vugt (vanvugt)]

Is this effectively an explanation/duplicate of bug 1745070?

[Khurshid Alam (khurshid-alam)]

bug 1745070 should be duplicate of this bug. I already send this bug link to debian.

[Khurshid Alam (khurshid-alam)]

I think Ubuntu should distro-patch it util it get accepted. Subscribing ubuntu-sponsors. See https://community.ubuntu.com/t/gnome-3-28-status/4141/24

[Simon Quigley (tsimonq2)]

Uploaded.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk3-nocsd - 3-1ubuntu1

---------------
gtk3-nocsd (3-1ubuntu1) bionic; urgency=medium

  * Improve the session detection fixing broken headerbars and decorations
    (LP: #1745206).

 -- Khurshid Alam <email address hidden> Fri, 02 Mar 2018 22:46:23 -0600